Skip to content

Commit 8ac0d4e

Browse files
committed
test(engine): compare the opted-out launch without a cast
1 parent 391cee7 commit 8ac0d4e

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎packages/engine/src/services/browserManager.test.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ describe("buildChromeArgs browser GPU mode", () => {
210210
expect(buildChromeArgs({ ...base, requiresWebGpu: false })).toEqual(buildChromeArgs(base));
211211
});
212212

213-
// SwiftShader draws canvas WebGPU only through its Vulkan backend with GPU compositing on (measured on Linux).
214213
it("runs an opted-in WebGPU composition on SwiftShader's Vulkan with GPU compositing on", () => {
215214
const args = buildChromeArgs(
216215
{ ...base, platform: "linux", requiresWebGpu: true },
@@ -233,10 +232,12 @@ describe("buildChromeArgs browser GPU mode", () => {
233232
["on a GPU", true, { browserGpuMode: "hardware", allowSoftwareWebGpu: true }],
234233
["under --disable-gpu", true, { disableGpu: true, allowSoftwareWebGpu: true }],
235234
] as const)("leaves the launch as it was %s", (_, requiresWebGpu, config) => {
236-
const { allowSoftwareWebGpu: _optIn, ...withoutOptIn } = config as Record<string, unknown>;
237235
expect(usesSoftwareWebGpu(requiresWebGpu, config)).toBe(false);
238236
expect(buildChromeArgs({ ...base, platform: "linux", requiresWebGpu }, config)).toEqual(
239-
buildChromeArgs({ ...base, platform: "linux", requiresWebGpu }, withoutOptIn),
237+
buildChromeArgs(
238+
{ ...base, platform: "linux", requiresWebGpu },
239+
{ ...config, allowSoftwareWebGpu: false },
240+
),
240241
);
241242
});
242243
});

0 commit comments

Comments
 (0)