Repository navigation
Commit 86ead17
committed
fix(core): resolve sub-composition start time through data-composition-file
createRuntimeStartTimeResolver's walk-up-to-host fallback (for an inner root
with no data-start of its own) only recognized a host carrying
data-composition-src or data-composition-id. Once inlining strips
data-composition-src and replaces it with data-composition-file, an
anonymous host (no data-composition-id of its own) matched neither check,
so the walk-up silently failed and the composition's own timeline got
seeked using its start time as the fallback (0) instead of the host's real
data-start.
This surfaced once the previous commit restored data-composition-id onto
the flattened wrapper for anonymous hosts: the composition's self-query
started resolving to that wrapper, but resolveStartForElement still
couldn't find its actual mount time through the host, so any composition
with real entrance/exit animation timing rendered stuck at t=0 (visually:
missing or frozen at its hidden initial state) instead of at the correct
point in its own timeline.1 parent 86d3693 commit 86ead17
2 files changed
Lines changed: 42 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
181 | 214 | | |
182 | 215 | | |
183 | 216 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
165 | | - | |
166 | | - | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
167 | 171 | | |
168 | 172 | | |
169 | 173 | | |
170 | 174 | | |
171 | 175 | | |
172 | | - | |
| 176 | + | |
| 177 | + | |
173 | 178 | | |
174 | 179 | | |
175 | 180 | | |
| |||
0 commit comments