Skip to content

Commit 8489979

Browse files
committed
fix(producer): prefer runtime duration for volume sampling
1 parent 81db1f4 commit 8489979

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

‎packages/producer/src/services/htmlCompiler.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1763,11 +1763,11 @@ h1 { font-size: 2rem; }`;
17631763
});
17641764

17651765
describe("discoverAudioVolumeAutomationFromTimeline", () => {
1766-
it("samples video-derived audio volume without firing GSAP callbacks", async () => {
1766+
it("prefers runtime duration over stale data-end while sampling video-derived audio", async () => {
17671767
class TestAudioElement {}
17681768
class TestVideoElement {
17691769
id = "bg-video";
1770-
dataset = { start: "0", duration: "1", volume: "0" };
1770+
dataset = { start: "0", end: "0.25", duration: "1", volume: "0" };
17711771
volume = 0;
17721772
}
17731773

‎packages/producer/src/services/htmlCompiler.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2134,10 +2134,10 @@ export async function discoverAudioVolumeAutomationFromTimeline(
21342134
const endAttr = Number.parseFloat(el.dataset.end ?? "");
21352135
const durationAttr = Number.parseFloat(el.dataset.duration ?? "");
21362136
const end =
2137-
Number.isFinite(endAttr) && endAttr > start
2138-
? endAttr
2139-
: Number.isFinite(durationAttr) && durationAttr > 0
2140-
? start + durationAttr
2137+
Number.isFinite(durationAttr) && durationAttr > 0
2138+
? start + durationAttr
2139+
: Number.isFinite(endAttr) && endAttr > start
2140+
? endAttr
21412141
: duration;
21422142
const sampleStart = Math.max(0, start);
21432143
const sampleEnd = Math.min(duration, end);

0 commit comments

Comments
 (0)