@@ -41,31 +41,17 @@ function extractPeaks(channelData: Float32Array, barCount: number): number[] {
4141 return peaks . map ( ( p ) => p / maxPeak ) ;
4242}
4343
44- /** Deterministic fake waveform as fallback (matches demo app). */
45- function fakePeaks ( url : string , count : number ) : number [ ] {
46- let seed = 0 ;
47- for ( let i = 0 ; i < url . length ; i ++ ) seed = ( ( seed << 5 ) - seed + url . charCodeAt ( i ) ) | 0 ;
48- seed = Math . abs ( seed ) || 42 ;
49- const rand = ( ) => {
50- seed = ( seed * 16807 ) % 2147483647 ;
51- return ( seed & 0x7fffffff ) / 2147483647 ;
52- } ;
53- const peaks : number [ ] = [ ] ;
54- for ( let i = 0 ; i < count ; i ++ ) {
55- const t = i / count ;
56- const envelope = 0.3 + 0.3 * Math . sin ( t * Math . PI * 3.2 ) + 0.2 * Math . sin ( t * Math . PI * 7.1 ) ;
57- peaks . push ( Math . max ( 0.05 , Math . min ( 1 , envelope * ( 0.4 + 0.6 * rand ( ) ) ) ) ) ;
58- }
59- return peaks ;
60- }
61-
6244// Module-level cache so decoded audio persists across re-renders and re-mounts
6345const peaksCache = new Map < string , number [ ] > ( ) ;
64- const decodeInFlight = new Map < string , Promise < number [ ] > > ( ) ;
46+ const decodeInFlight = new Map < string , Promise < number [ ] | null > > ( ) ;
47+ // URLs whose fetch/decode failed — render the degraded state instead of
48+ // refetching (and never fabricate plausible-looking peaks the user might
49+ // trim or beat-align against).
50+ const decodeFailed = new Set < string > ( ) ;
6551
6652/**
6753 * Audio waveform rendered from real PCM data via Web Audio API.
68- * Falls back to a deterministic fake pattern if decoding fails.
54+ * Shows an explicit "waveform unavailable" degraded state if decoding fails.
6955 * Bars grow from bottom to top, rendered as CSS divs for zoom resilience.
7056 */
7157export const AudioWaveform = memo ( function AudioWaveform ( {
@@ -81,9 +67,10 @@ export const AudioWaveform = memo(function AudioWaveform({
8167 const roRef = useRef < ResizeObserver | null > ( null ) ;
8268 const cacheKey = waveformUrl ?? audioUrl ;
8369 const [ peaks , setPeaks ] = useState < number [ ] | null > ( peaksCache . get ( cacheKey ) ?? null ) ;
70+ const [ decodeError , setDecodeError ] = useState ( ( ) => decodeFailed . has ( cacheKey ) ) ;
8471
8572 useEffect ( ( ) => {
86- if ( peaks || ! cacheKey ) return ;
73+ if ( peaks || decodeError || ! cacheKey ) return ;
8774
8875 let cancelled = false ;
8976
@@ -105,23 +92,28 @@ export const AudioWaveform = memo(function AudioWaveform({
10592 } )
10693 . then ( ( decoded ) => extractPeaks ( decoded . getChannelData ( 0 ) , 4000 ) )
10794 )
108- . catch ( ( ) => fakePeaks ( cacheKey , 4000 ) )
109- . then ( ( p ) => {
95+ . then ( ( p : number [ ] ) => {
11096 peaksCache . set ( cacheKey , p ) ;
111- return p ;
97+ return p as number [ ] | null ;
98+ } )
99+ . catch ( ( ) => {
100+ decodeFailed . add ( cacheKey ) ;
101+ return null ;
112102 } )
113103 . finally ( ( ) => decodeInFlight . delete ( cacheKey ) ) ;
114104
115105 decodeInFlight . set ( cacheKey , promise ) ;
116106 }
117107
118108 promise . then ( ( p ) => {
119- if ( ! cancelled ) setPeaks ( p ) ;
109+ if ( cancelled ) return ;
110+ if ( p ) setPeaks ( p ) ;
111+ else setDecodeError ( true ) ;
120112 } ) ;
121113 return ( ) => {
122114 cancelled = true ;
123115 } ;
124- } , [ audioUrl , waveformUrl , cacheKey , peaks ] ) ;
116+ } , [ audioUrl , waveformUrl , cacheKey , peaks , decodeError ] ) ;
125117
126118 // Draw bars into the container using innerHTML (fast, zoom-resilient)
127119 const draw = useCallback ( ( ) => {
@@ -185,16 +177,37 @@ export const AudioWaveform = memo(function AudioWaveform({
185177 < div ref = { setContainerRef } className = "absolute inset-0 overflow-hidden" >
186178 < div ref = { barsRef } className = "absolute left-0 right-0 bottom-0" style = { { top : 16 } } />
187179 { /* Shimmer while decoding */ }
188- { ! peaks && (
180+ { ! peaks && ! decodeError && (
189181 < div
190- className = "absolute left-0 right-0 bottom-0 animate-pulse"
182+ className = "absolute left-0 right-0 bottom-0 animate-pulse motion-reduce:animate-none "
191183 style = { {
192184 top : 16 ,
193185 background :
194186 "linear-gradient(90deg, rgba(255,255,255,0.02) 0%, rgba(255,255,255,0.05) 50%, rgba(255,255,255,0.02) 100%)" ,
195187 } }
196188 />
197189 ) }
190+ { /* Degraded state — decode failed; render an explicit flat placeholder
191+ instead of fabricated peaks the user might edit against. */ }
192+ { decodeError && (
193+ < div
194+ className = "absolute left-0 right-0 flex items-center justify-center gap-1.5"
195+ style = { { top : 16 , bottom : 0 } }
196+ >
197+ < div
198+ className = "absolute left-0 right-0"
199+ style = { {
200+ bottom : "20%" ,
201+ height : 2 ,
202+ background :
203+ "repeating-linear-gradient(90deg, rgba(75,163,210,0.35) 0 2px, transparent 2px 5px)" ,
204+ } }
205+ />
206+ < span className = "relative text-[8px] text-neutral-500 bg-black/50 px-1 rounded" >
207+ waveform unavailable
208+ </ span >
209+ </ div >
210+ ) }
198211 < div className = "absolute top-0 left-0 right-0 px-1.5 py-0.5 z-10" >
199212 < span
200213 className = "text-[9px] font-semibold truncate block leading-tight"
0 commit comments