Repository navigation
Commit 77a45f6
fix(producer): fail loudly when a capture route cannot blur (#4026)
A render on the layered HDR route accepted `motionBlur` and returned frames
with no blur in them. The HDR compositor runs its own capture loop, seeking
and blitting each layer itself, so a frame never reaches the sub-frame
accumulation branch. The engine's own guard cannot catch it, because from
inside the session everything looks supported: screenshot capture mode, PNG
frames, and no video injector on a composition with no video.
This is the third time the question "does this route support motion blur"
has been answered implicitly by whichever code path happened to run, and the
third time it came out wrong and silent. `assertMotionBlurSupported` gives
that question one owner and one answer. The route it takes is the capture
plan's own `kind`, already the single value the capture stages consume, so
it cannot drift from the route that actually runs, and a new plan kind with
no entry in its table fails the typecheck rather than inheriting silence.
It sits inside `syncCapturePlan`, which runs on the initial plan and after
every replan, so a route a render falls back into is checked too.
Distributed renders are out of scope on purpose and recorded as such:
`DistributedRenderConfig` has no `motionBlur` field and is not built from
`RenderConfig`, so motion blur cannot be requested on one. There is nothing
to reject and no dead call site.
The explicit unsupported-mode error for layered HDR is the design in #4013
by Dante-dan.
Co-authored-by: Miguel Ángel <[email protected]>1 parent 71bb887 commit 77a45f6
3 files changed
Lines changed: 96 additions & 0 deletions
File tree
- packages/producer/src/services
- render
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
| 193 | + | |
193 | 194 | | |
194 | 195 | | |
195 | 196 | | |
| |||
3971 | 3972 | | |
3972 | 3973 | | |
3973 | 3974 | | |
| 3975 | + | |
| 3976 | + | |
| 3977 | + | |
3974 | 3978 | | |
3975 | 3979 | | |
3976 | 3980 | | |
| |||
0 commit comments