Skip to content

Commit 4c02c8f

Browse files
committed
fix(producer): withhold de parallel router below a machine ram floor
1 parent 0809c98 commit 4c02c8f

2 files changed

Lines changed: 42 additions & 1 deletion

File tree

‎packages/producer/src/services/renderOrchestrator.test.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1749,12 +1749,28 @@ describe("shouldPreferParallelDrawElement (DE parallel router)", () => {
17491749
probeDeGated: false,
17501750
experimentalParallelDeOptIn: false,
17511751
routerEnabled: true,
1752+
totalMemoryMb: 32768,
1753+
minMemoryMb: 24576,
17521754
};
17531755

17541756
it("routes an auto-resolved multi-worker render for an eligible long comp", () => {
17551757
expect(shouldPreferParallelDrawElement(eligible)).toBe(true);
17561758
});
17571759

1760+
it("withholds the parallel bet below the RAM floor (16 GB black-slab report)", () => {
1761+
expect(shouldPreferParallelDrawElement({ ...eligible, totalMemoryMb: 16384 })).toBe(false);
1762+
});
1763+
1764+
it("routes exactly at the RAM floor", () => {
1765+
expect(shouldPreferParallelDrawElement({ ...eligible, totalMemoryMb: 24576 })).toBe(true);
1766+
});
1767+
1768+
it("minMemoryMb <= 0 disables the RAM guard", () => {
1769+
expect(
1770+
shouldPreferParallelDrawElement({ ...eligible, totalMemoryMb: 8192, minMemoryMb: 0 }),
1771+
).toBe(true);
1772+
});
1773+
17581774
it("is disabled by default (routerEnabled: false is the shipped default)", () => {
17591775
expect(shouldPreferParallelDrawElement({ ...eligible, routerEnabled: false })).toBe(false);
17601776
});

‎packages/producer/src/services/renderOrchestrator.ts‎

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ import {
7676
isDrawElementVerificationError,
7777
} from "@hyperframes/engine";
7878
import { join, dirname, resolve } from "path";
79+
import { totalmem } from "node:os";
7980
import { randomUUID } from "crypto";
8081
import { fileURLToPath } from "url";
8182
import {
@@ -1125,6 +1126,10 @@ export function shouldPreferParallelDrawElement(args: {
11251126
experimentalParallelDeOptIn: boolean;
11261127
/** HF_DE_PARALLEL_ROUTER === "true" — the router's own kill switch, default off. */
11271128
routerEnabled: boolean;
1129+
/** Machine RAM (os.totalmem, MB). */
1130+
totalMemoryMb: number;
1131+
/** RAM floor for routing; <=0 disables the guard. */
1132+
minMemoryMb: number;
11281133
}): boolean {
11291134
return (
11301135
args.routerEnabled &&
@@ -1139,7 +1144,14 @@ export function shouldPreferParallelDrawElement(args: {
11391144
!args.layeredOrEffectRoute &&
11401145
!args.supersampling &&
11411146
!args.probeDeGated &&
1142-
!args.experimentalParallelDeOptIn
1147+
!args.experimentalParallelDeOptIn &&
1148+
// RAM floor: routed parallel DE runs 3 concurrent hardware-GPU Chrome
1149+
// instances. On a 16 GB machine that produced vertical black slabs in the
1150+
// final MP4 (wild report, CLI 0.7.52) — compositor tiles evicted under
1151+
// GPU/memory pressure, and sampled self-verify can miss partial-frame
1152+
// damage. Single-worker DE (the inversion) stays available below the
1153+
// floor; only the parallel bet is withheld.
1154+
(args.minMemoryMb <= 0 || args.totalMemoryMb >= args.minMemoryMb)
11431155
);
11441156
}
11451157

@@ -1914,6 +1926,17 @@ export async function executeRenderJob(
19141926
const deParallelMinFrames = Number.isFinite(deParallelMinFramesNum)
19151927
? deParallelMinFramesNum
19161928
: 2000;
1929+
// RAM floor default 24 GB: the wild black-slab report was a 16 GB
1930+
// machine; every clean routed cohort in telemetry so far is >=24 GB.
1931+
// HF_DE_PARALLEL_MIN_MEM_MB overrides (0 disables the guard).
1932+
const deParallelMinMemRaw = process.env.HF_DE_PARALLEL_MIN_MEM_MB;
1933+
const deParallelMinMemNum =
1934+
deParallelMinMemRaw === undefined || deParallelMinMemRaw.trim() === ""
1935+
? 24576
1936+
: Number(deParallelMinMemRaw);
1937+
const deParallelMinMemoryMb = Number.isFinite(deParallelMinMemNum)
1938+
? deParallelMinMemNum
1939+
: 24576;
19171940
const deParallelRouterEligible = shouldPreferParallelDrawElement({
19181941
workerCount: WOULD_RESOLVE_MULTI_WORKER,
19191942
requestedWorkers: job.config.workers,
@@ -1933,6 +1956,8 @@ export async function executeRenderJob(
19331956
process.env.PRODUCER_EXPERIMENTAL_FAST_CAPTURE === "true" ||
19341957
process.env.HF_DE_PARALLEL_STREAM === "true",
19351958
routerEnabled: deParallelRouterEnabled,
1959+
totalMemoryMb: Math.round(totalmem() / (1024 * 1024)),
1960+
minMemoryMb: deParallelMinMemoryMb,
19361961
});
19371962
if (
19381963
job.config.workers === undefined &&

0 commit comments

Comments
 (0)