Skip to content

Commit 42c508b

Browse files
committed
test(producer): split the scripted capture attempt into small helpers
1 parent 7e17f60 commit 42c508b

1 file changed

Lines changed: 70 additions & 42 deletions

File tree

‎packages/producer/src/services/renderOrchestrator.stall.test.ts‎

Lines changed: 70 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,76 @@ const capture = vi.hoisted(() => ({
1818
shaderTransitions: false,
1919
}));
2020

21+
type ScriptedFrame = { dir: string; index: number };
22+
23+
function listFrames(tasks: WorkerTask[]): ScriptedFrame[] {
24+
return tasks.flatMap((task) =>
25+
Array.from({ length: task.endFrame - task.startFrame }, (_, i) => ({
26+
dir: task.outputDir,
27+
index: task.startFrame + i,
28+
})),
29+
);
30+
}
31+
32+
// "spread" lands the first frame of each worker's range, leaving four missing ranges.
33+
function landedFrames(script: AttemptScript, frames: ScriptedFrame[]): ScriptedFrame[] {
34+
if (script === "spread") return frames.filter((frame) => frame.index % 10 === 0);
35+
return frames.slice(0, script === "stall" ? 3 : frames.length);
36+
}
37+
38+
function writeFrame(frame: ScriptedFrame, extension: string): void {
39+
mkdirSync(frame.dir, { recursive: true });
40+
writeFileSync(
41+
join(frame.dir, formatCaptureFrameName(frame.index, extension)),
42+
"frame bytes over the 8-byte placeholder floor",
43+
);
44+
}
45+
46+
function neverSettlesUntilAborted(signal: AbortSignal): Promise<never> {
47+
return new Promise((_, reject) =>
48+
signal?.addEventListener("abort", () => reject(new Error("worker cancelled")), { once: true }),
49+
);
50+
}
51+
52+
function wait(ms: number): Promise<unknown> {
53+
return new Promise((resolve) => setTimeout(resolve, ms));
54+
}
55+
56+
async function landFrame(
57+
frame: ScriptedFrame,
58+
extension: string,
59+
delayMs: number,
60+
signal: AbortSignal,
61+
): Promise<void> {
62+
await wait(delayMs);
63+
if (signal?.aborted) throw new Error("worker cancelled");
64+
writeFrame(frame, extension);
65+
}
66+
67+
async function runScriptedAttempt(
68+
tasks: WorkerTask[],
69+
extension: string,
70+
signal: AbortSignal,
71+
onProgress: (progress: object) => void,
72+
): Promise<[]> {
73+
capture.calls += 1;
74+
const script = capture.scripts.shift() ?? "stall";
75+
const pace = typeof script === "object" ? script : null;
76+
const frames = listFrames(tasks);
77+
let captured = 0;
78+
for (const frame of landedFrames(script, frames)) {
79+
const delayMs = pace && captured === 0 ? pace.firstFrameAfterMs : 1_000;
80+
await landFrame(frame, extension, delayMs, signal);
81+
captured += 1;
82+
onProgress({ capturedFrames: captured, totalFrames: frames.length, activeWorkers: 1 });
83+
if (pace) await wait(pace.frameEveryMs - 1_000);
84+
}
85+
if (!pace) await neverSettlesUntilAborted(signal);
86+
return [];
87+
}
88+
2189
vi.mock("@hyperframes/engine", async (importOriginal) => {
2290
const engine = await importOriginal<typeof import("@hyperframes/engine")>();
23-
const wait = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
2491
return {
2592
...engine,
2693
assertConfiguredFfmpegBinariesExist: () => {},
@@ -32,54 +99,15 @@ vi.mock("@hyperframes/engine", async (importOriginal) => {
3299
getCapturePerfSummary: () => ({}),
33100
// Sequential disk: three quick frames, then every frame takes 70 s.
34101
captureFrame: (_session: unknown, index: number) => wait(index < 3 ? 1_000 : 70_000),
35-
executeParallelCapture: async (
102+
executeParallelCapture: (
36103
_url: string,
37104
_workDir: string,
38105
tasks: WorkerTask[],
39106
options: { format?: "jpeg" | "png" },
40107
_hook: unknown,
41108
signal: AbortSignal,
42109
onProgress: (progress: object) => void,
43-
) => {
44-
capture.calls += 1;
45-
const script = capture.scripts.shift() ?? "stall";
46-
const frames = tasks.flatMap((task) =>
47-
Array.from({ length: task.endFrame - task.startFrame }, (_, i) => ({
48-
dir: task.outputDir,
49-
index: task.startFrame + i,
50-
})),
51-
);
52-
const stalls = script === "stall" || script === "spread";
53-
// "spread" lands the first frame of each worker's range, leaving four missing ranges.
54-
const landed =
55-
script === "spread"
56-
? frames.filter((frame) => frame.index % 10 === 0)
57-
: frames.slice(0, script === "stall" ? 3 : frames.length);
58-
let captured = 0;
59-
for (const frame of landed) {
60-
await wait(captured === 0 && !stalls ? script.firstFrameAfterMs : 1_000);
61-
if (signal?.aborted) throw new Error("worker cancelled");
62-
mkdirSync(frame.dir, { recursive: true });
63-
writeFileSync(
64-
join(
65-
frame.dir,
66-
formatCaptureFrameName(frame.index, engine.frameFileExtension(options.format)),
67-
),
68-
"frame bytes over the 8-byte placeholder floor",
69-
);
70-
captured += 1;
71-
onProgress({ capturedFrames: captured, totalFrames: frames.length, activeWorkers: 1 });
72-
if (!stalls) await wait(script.frameEveryMs - 1_000);
73-
}
74-
if (stalls) {
75-
await new Promise((_, reject) =>
76-
signal?.addEventListener("abort", () => reject(new Error("worker cancelled")), {
77-
once: true,
78-
}),
79-
);
80-
}
81-
return [];
82-
},
110+
) => runScriptedAttempt(tasks, engine.frameFileExtension(options.format), signal, onProgress),
83111
};
84112
});
85113
vi.mock("./fileServer.js", async (importOriginal) => ({

0 commit comments

Comments
 (0)