Skip to content

Commit 41c219f

Browse files
committed
refactor(lint): drop a comment and unused first-entry lines from the grouping change
1 parent 54d8c10 commit 41c219f

2 files changed

Lines changed: 0 additions & 19 deletions

File tree

‎packages/cli/src/utils/lintProject.test.ts‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -407,8 +407,6 @@ describe("audio_src_not_found", () => {
407407
const { totalErrors, results } = await lintProject(project);
408408

409409
expect(totalErrors).toBeGreaterThan(0);
410-
const first = results[0];
411-
expect(first).toBeDefined();
412410
const finding = allFindings(results).find((f) => f.code === "audio_src_not_found");
413411
expect(finding).toBeDefined();
414412
expect(finding?.severity).toBe("error");
@@ -421,8 +419,6 @@ describe("audio_src_not_found", () => {
421419

422420
const { results } = await lintProject(project);
423421

424-
const first = results[0];
425-
expect(first).toBeDefined();
426422
const finding = allFindings(results).find((f) => f.code === "audio_src_not_found");
427423
expect(finding).toBeUndefined();
428424
});
@@ -438,8 +434,6 @@ describe("audio_src_not_found", () => {
438434

439435
const { results } = await lintProject(project);
440436

441-
const first = results[0];
442-
expect(first).toBeDefined();
443437
const finding = allFindings(results).find((f) => f.code === "audio_src_not_found");
444438
expect(finding).toBeUndefined();
445439
});
@@ -453,8 +447,6 @@ describe("audio_src_not_found", () => {
453447
const { totalErrors, results } = await lintProject(project);
454448

455449
expect(totalErrors).toBeGreaterThan(0);
456-
const first = results[0];
457-
expect(first).toBeDefined();
458450
const finding = allFindings(results).find((f) => f.code === "audio_src_not_found");
459451
expect(finding).toBeDefined();
460452
});
@@ -472,8 +464,6 @@ describe("audio_src_not_found", () => {
472464

473465
const { results } = await lintProject(project);
474466

475-
const first = results[0];
476-
expect(first).toBeDefined();
477467
const finding = allFindings(results).find((f) => f.code === "audio_src_not_found");
478468
expect(finding).toBeUndefined();
479469
});
@@ -487,8 +477,6 @@ describe("audio_src_not_found", () => {
487477

488478
const { results } = await lintProject(project);
489479

490-
const first = results[0];
491-
expect(first).toBeDefined();
492480
const finding = allFindings(results).find((f) => f.code === "audio_src_not_found");
493481
expect(finding).toBeUndefined();
494482
});
@@ -501,8 +489,6 @@ describe("audio_src_not_found", () => {
501489

502490
const { results } = await lintProject(project);
503491

504-
const first = results[0];
505-
expect(first).toBeDefined();
506492
const finding = allFindings(results).find((f) => f.code === "audio_src_not_found");
507493
expect(finding).toBeUndefined();
508494
});
@@ -551,8 +537,6 @@ describe("audio_src_not_found", () => {
551537

552538
const { results } = await lintProject(project);
553539

554-
const first = results[0];
555-
expect(first).toBeDefined();
556540
const finding = allFindings(results).find((f) => f.code === "audio_src_not_found");
557541
expect(finding).toBeUndefined();
558542
});
@@ -569,8 +553,6 @@ describe("audio_src_not_found", () => {
569553

570554
const { results } = await lintProject(project);
571555

572-
const first = results[0];
573-
expect(first).toBeDefined();
574556
const finding = allFindings(results).find((f) => f.code === "audio_src_not_found");
575557
expect(finding).toBeDefined();
576558
// The original (un-rewritten) src is what surfaces in the message so the

‎packages/lint/src/project.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,6 @@ export async function lintProject(
259259
...(await lintHevcPreviewCodec(collectLocalVideoCandidates(projectDir, allHtmlSources))),
260260
];
261261
for (const finding of projectFindings) {
262-
// Filed under the composition it names, so every surface labels it by that file.
263262
const ownFile = finding.file && resolve(projectDir, finding.file);
264263
const owner =
265264
results.find((entry) => resolve(projectDir, entry.file) === ownFile)?.result ?? rootResult;

0 commit comments

Comments
 (0)