Skip to content

Commit 353b9eb

Browse files
fix(producer): scale frame coverage by playback rate (#3542)
1 parent ece09d8 commit 353b9eb

2 files changed

Lines changed: 15 additions & 2 deletions

File tree

‎packages/producer/src/services/render/videoFrameCoverage.test.ts‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ function makeVideo(overrides: Partial<VideoElement> & { id: string }): VideoElem
1919
start: overrides.start ?? 0,
2020
end: overrides.end ?? 1,
2121
mediaStart: overrides.mediaStart ?? 0,
22+
playbackRate: overrides.playbackRate,
2223
loop: overrides.loop ?? false,
2324
hasAudio: overrides.hasAudio ?? false,
2425
};
@@ -133,6 +134,16 @@ describe("resolveVideoCoverageThreshold", () => {
133134
});
134135

135136
describe("computeVideoFrameCoverage", () => {
137+
it("expects only the source frames consumed by a slowed authored slot", () => {
138+
const videos = [makeVideo({ id: "slow", start: 0, end: 4, playbackRate: 0.5 })];
139+
const extracted = [makeExtracted("slow", 60, { durationSeconds: 4 })];
140+
141+
const reports = computeVideoFrameCoverage(videos, extracted, 30);
142+
143+
expect(reports[0]).toMatchObject({ expectedFrames: 60, capturedFrames: 60, ratio: 1 });
144+
expect(() => assertVideoFrameCoverage(reports, 0.95)).not.toThrow();
145+
});
146+
136147
it("reports 1.0 ratio when every video delivered its authored window", () => {
137148
const videos = [
138149
makeVideo({ id: "a", start: 0, end: 1 }),

‎packages/producer/src/services/render/videoFrameCoverage.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
*/
4646

4747
import { parseHTML } from "linkedom";
48-
import { fpsToNumber, toFps, type FpsInput } from "@hyperframes/core";
48+
import { fpsToNumber, normalizePlaybackRate, toFps, type FpsInput } from "@hyperframes/core";
4949
import {
5050
extractionFrameCountForDuration,
5151
resolvePlayableVideoDuration,
@@ -166,7 +166,9 @@ function expectedFramesForVideo(
166166
fps: FpsInput,
167167
): number {
168168
const rounding = entry && !entry.metadata.isVFR ? "nearest" : "ceil";
169-
const slotFrames = expectedFramesForClip(video.start, video.end, fps, rounding);
169+
const playbackRate = normalizePlaybackRate(video.playbackRate ?? 1);
170+
const slotSourceDuration = Math.max(0, video.end - video.start) * playbackRate;
171+
const slotFrames = expectedFramesForClip(0, slotSourceDuration, fps, rounding);
170172
if (!entry) return slotFrames;
171173

172174
// A short source in a longer slot has a legitimate delivery ceiling of

0 commit comments

Comments
 (0)