Skip to content

Commit 28315d1

Browse files
committed
chore(studio-server): keep the split margin's comments within the file's share
1 parent 38813a4 commit 28315d1

2 files changed

Lines changed: 3 additions & 9 deletions

File tree

‎packages/parsers/src/compositionContract.ts‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88

99
export const COMPOSITION_CONTRACT_VERSION = 1 as const;
1010

11-
/** The least a split leaves on either side of its cut, in seconds. Timing is written to the millisecond, so a cut
12-
* closer than this to an edge (a second split at the same playhead) would write a half with no length. */
11+
/** Least a split leaves either side of its cut (s); timing is written to the ms, so less rounds to a 0-length half. */
1312
export const SPLIT_BOUNDARY_EPSILON_S = 0.03;
1413

1514
export const COMPOSITION_ATTRIBUTES = Object.freeze({
@@ -226,11 +225,8 @@ function derivedEndsAreConsistent(parsedEnd: number, canonicalEnd: number): bool
226225
//
227226
// The compiler (`compileTimingAttrs` in @hyperframes/core) writes
228227
// `data-end = data-start + data-duration` into the bundled HTML so the runtime
229-
// can key off a single attribute. That derived attribute is legitimate — it is
230-
// not a legacy authoring shape. Treating it as `deprecated-end` here made the
231-
// linter fire `deprecated_data_end` on the compiler's own output whenever
232-
// StaticGuard re-validated a bundled composition, producing a false-positive
233-
// cluster reported in the field (n=25+ across cli-feedback crons 61-68).
228+
// can key off a single attribute. That derived attribute is not a legacy
229+
// authoring shape, so the compiler's own output is never flagged.
234230
//
235231
// We keep `deprecated-end` for the truly legacy shape (see `readLegacyEnd` —
236232
// `data-end` present without `data-duration`) and for the *conflicting* case

‎packages/studio-server/src/helpers/sourceMutation.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,6 @@ export function splitElementInHtml(
459459
start = fallbackTiming.start;
460460
duration = fallbackTiming.duration;
461461
}
462-
// The same margin Studio's timeline checks, held here where the file is cut: the client's copy of the clip can be a
463-
// split behind, and a cut a hair inside an edge rounds to a half with no length.
464462
if (
465463
duration <= 0 ||
466464
splitTime < start + SPLIT_BOUNDARY_EPSILON_S ||

0 commit comments

Comments
 (0)