Skip to content

Commit 19258ea

Browse files
committed
fix(render): cap final mux to video duration
1 parent afc4e96 commit 19258ea

3 files changed

Lines changed: 11 additions & 1 deletion

File tree

‎packages/engine/src/services/chunkEncoder.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,8 @@ export interface MuxVideoWithAudioOptions extends Partial<
7979
audioCodec?: "aac";
8080
/** Preserve a priming edit list known to have been created by AAC re-encoding. */
8181
preserveAudioPrimingEditList?: boolean;
82+
/** Hard cap copied audio to the already-encoded video's exact duration. */
83+
durationSeconds?: number;
8284
}
8385

8486
async function shouldCopyAacSidecar(
@@ -706,6 +708,9 @@ export async function muxVideoWithAudio(
706708
// output container metadata. `-c:v copy` is retained; no re-encode.
707709
args.push("-r", fpsToFfmpegArg(fps));
708710
}
711+
if (config?.durationSeconds !== undefined) {
712+
args.push("-t", String(config.durationSeconds));
713+
}
709714
args.push("-y", outputPath);
710715

711716
const processTimeout = config?.ffmpegProcessTimeout ?? DEFAULT_CONFIG.ffmpegProcessTimeout;

‎packages/producer/src/services/distributed/assemble.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,11 @@ export async function assemble(
323323
audioForMux,
324324
muxOutputPath,
325325
abortSignal,
326-
{ audioCodec: "aac", preserveAudioPrimingEditList },
326+
{
327+
audioCodec: "aac",
328+
preserveAudioPrimingEditList,
329+
durationSeconds: padTrimResult.targetDurationSeconds,
330+
},
327331
{ num: plan.dimensions.fpsNum, den: plan.dimensions.fpsDen },
328332
);
329333
if (!muxResult.success) {

‎packages/producer/src/services/render/stages/assembleStage.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ export async function runAssembleStage(input: AssembleStageInput): Promise<Assem
7979
{
8080
audioCodec: "aac",
8181
preserveAudioPrimingEditList: normalizeResult.operation === "trim",
82+
durationSeconds: normalizeResult.targetDurationSeconds,
8283
},
8384
job.config.fps,
8485
);

0 commit comments

Comments
 (0)