Skip to content

Commit 11a0725

Browse files
vanceingallsclaude
andcommitted
fix(producer): complete deferred drawElement init on the disk capture path
Review (miga): a probe-initialized video comp falling back to the disk path kept deInitDeferred and silently stayed in screenshot mode — a regression for PRODUCER_EXPERIMENTAL_FAST_CAPTURE=true renders that previously ran drawElement there. Complete the deferred init on the sequential disk path under the same explicit-opt-in test the orchestrator clamp uses; default-on renders stay on the screenshot baseline (this path has no drain-time self-verification, per the #1998 confinement rule). Validated: video comp + PRODUCER_ENABLE_STREAMING_ENCODE=false + explicit opt-in logs "(deferred drawElement init)" completion on capture_disk and renders correct video pixels. Co-Authored-By: Claude Fable 5 <[email protected]>
1 parent c0a6188 commit 11a0725

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

‎packages/producer/src/services/render/stages/captureStage.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ import {
4646
captureFrameToBufferPipelined,
4747
writeCapturedFrame,
4848
closeCaptureSession,
49+
completeDeferredDrawElementInit,
4950
createCaptureSession,
5051
getCapturePerfSummary,
5152
initializeSession,
@@ -260,6 +261,13 @@ export async function runCaptureStage(input: CaptureStageInput): Promise<Capture
260261
try {
261262
if (!session.isInitialized) {
262263
await initializeSession(session);
264+
} else if (process.env.PRODUCER_EXPERIMENTAL_FAST_CAPTURE === "true") {
265+
// Deferred drawElement init (probe-initialized video comps). The disk
266+
// path has no drain-time self-verification, so only an explicit opt-in
267+
// completes it here — mirroring the orchestrator clamp that routes
268+
// default-on drawElement renders to the screenshot baseline on this
269+
// path. No-op unless the session is deferred with an injector attached.
270+
await completeDeferredDrawElementInit(session);
263271
}
264272
assertNotAborted();
265273
lastBrowserConsole = session.browserConsoleBuffer;

0 commit comments

Comments
 (0)