Skip to content

Commit 1070a48

Browse files
vanceingallsclaude
andcommitted
fix(core): keep the comment share where it was
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 85c8bdf commit 1070a48

2 files changed

Lines changed: 0 additions & 5 deletions

File tree

‎packages/core/src/runtime/media.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,6 @@ export function syncRuntimeMedia(params: {
372372
effectiveVolume: number,
373373
authorVolume: number,
374374
clipGain: number,
375-
/** `authorVolume` without the clip's fade, for a transport that books the fade on its own clock. */
376375
unfadedVolume?: number,
377376
) => void;
378377
/** Is THIS element owned by the Web Audio transport? Owned → mute it (transport
@@ -540,7 +539,6 @@ export function syncRuntimeMedia(params: {
540539
const effectiveVolume = silencedByHidden ? 0 : clampVolume(authorVolume * userVol);
541540
if (Math.abs(el.volume - effectiveVolume) > 1e-6) el.volume = effectiveVolume;
542541
lastRuntimeAppliedVolume.set(el, effectiveVolume);
543-
// the level without its fade only where a fade changed it, for a transport that books fades on its own clock
544542
if (unfadedVolume === authorVolume)
545543
params.onElementVolume?.(el, effectiveVolume, authorVolume, preFxGain);
546544
else params.onElementVolume?.(el, effectiveVolume, authorVolume, preFxGain, unfadedVolume);

‎packages/core/src/runtime/webAudioTransport.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,9 +1011,6 @@ export class WebAudioTransport {
10111011
* the preview path while the render honoured it — the exact preview/render
10121012
* divergence this ceiling exists to close. Automation lanes hid it, because
10131013
* they schedule ramps onto the param directly and never pass through here.
1014-
*
1015-
* `volume` carries the clip's fade as the sync tick reads it; `unfadedVolume` is the same level without it, for a
1016-
* source whose fades are booked on the audio clock (`fadeNode`), so the fade is not applied twice.
10171014
*/
10181015
setElementVolume(
10191016
el: HTMLMediaElement,

0 commit comments

Comments
 (0)