Skip to content

Commit 0cde884

Browse files
fix(cli): macOS 12 users get Chrome 150 automatically and can render (#4185)
* fix(cli): pick a macOS 12 capable Chrome on macOS 12 instead of the pinned build * test(engine): stop building subprocess eval scripts from strings
1 parent 038851c commit 0cde884

16 files changed

Lines changed: 509 additions & 95 deletions

‎packages/cli/src/browser/macosOldChromeCrash.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,16 @@ export function macosOldChromeCrashRemediation(errorMessage: string): string | u
5858
if (!isMacosOldChromeCrashError(errorMessage)) return undefined;
5959
return [
6060
"chrome-headless-shell crashed at launch (macOS dyld: Symbol not found in VideoToolbox).",
61-
"The pinned Chromium build requires macOS 13+; on macOS 12 or older, install an older",
62-
"chrome-headless-shell and point hyperframes at it:",
61+
"The pinned Chromium build requires macOS 13+. HyperFrames installs Chrome 150 on macOS 12 by",
62+
"itself, so this crash means a newer browser was supplied. Unset the override, or point it at",
63+
"an older chrome-headless-shell:",
6364
"",
6465
" npx @puppeteer/browsers install chrome-headless-shell@150",
65-
' export HYPERFRAMES_BROWSER_PATH="$HOME/.cache/puppeteer/chrome-headless-shell/mac-150.0.7422.0/chrome-headless-shell-mac-x64/chrome-headless-shell"',
66+
' export HYPERFRAMES_BROWSER_PATH="$HOME/.cache/puppeteer/chrome-headless-shell/mac-150.0.7871.124/chrome-headless-shell-mac-x64/chrome-headless-shell"',
6667
"",
6768
"(PRODUCER_HEADLESS_SHELL_PATH works as an alias for the same override.)",
68-
"Any working chrome-headless-shell build resolves this — the exact version above is one",
69-
"known-good macOS-12 combination. Alternatively, point HYPERFRAMES_BROWSER_PATH at your",
70-
'installed Google Chrome ("/Applications/Google Chrome.app/Contents/MacOS/Google Chrome")',
71-
"to fall back to the screenshot capture path.",
69+
"Alternatively, point HYPERFRAMES_BROWSER_PATH at your installed Google Chrome",
70+
'("/Applications/Google Chrome.app/Contents/MacOS/Google Chrome") to fall back to the screenshot',
71+
"capture path.",
7272
].join("\n");
7373
}

0 commit comments

Comments
 (0)