You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 09c04d0
Browse filesBrowse the repository at this point in the historyBrowse files
Expose the existing automatic HDR promotion decision in `check --json` and
emit one attributed WARN line during automatic HDR renders. Reuse the current
HDR source classification so output selection and HDR flags are unchanged.
Add regression coverage for JSON attribution and the single render warning.
Co-authored-by: miguel.sierra <[email protected]>
-`packages/engine/src/utils/hdr.ts`, `packages/engine/src/index.ts`, and `packages/engine/src/utils/hdr.test.ts` — define, export, and test the canonical HDR auto-promotion report and warning format.
10
+
-`packages/cli/src/utils/hdrPromotion.ts`, `packages/cli/src/utils/hdrPromotion.test.ts`, `packages/cli/src/utils/checkPipeline.ts`, `packages/cli/src/utils/checkTypes.ts`, and `packages/cli/src/commands/check.test.ts` — detect local HDR assets and include their triggering path plus BT.2020 / HEVC Main10 output in `check --json`.
11
+
-`packages/producer/src/services/render/hdrMode.ts`, `packages/producer/src/services/render/hdrMode.test.ts`, and `packages/producer/src/services/renderOrchestrator.ts` — attribute automatic HDR promotion to the probed composition asset and emit one WARN line for a no-flag render.
12
+
13
+
## Why this is the right fix
14
+
15
+
Automatic HDR promotion already selected the correct pipeline, but its diagnostics did not expose which source triggered the decision and render logged the promotion only at INFO. The change reuses the existing HDR classification and native-source ID sets, so rendering behavior and flags are unchanged while CLI JSON and render logs carry the same actionable attribution.
16
+
17
+
## What I considered and rejected
18
+
19
+
Deriving the asset name from extracted temporary frame paths was rejected because those paths are implementation details and can no longer identify the authored composition source.
20
+
21
+
## Tests
22
+
23
+
-`bunx vitest run packages/engine/src/utils/hdr.test.ts packages/cli/src/utils/hdrPromotion.test.ts packages/cli/src/commands/check.test.ts packages/producer/src/services/render/hdrMode.test.ts` — 88 passed.
24
+
-`bun run --cwd packages/engine typecheck` — passed.
25
+
-`bun run --cwd packages/cli typecheck` — passed.
26
+
-`bun run --cwd packages/producer typecheck` — passed.
0 commit comments