Skip to content

Commit 0665249

Browse files
authored
fix(playground): render initialization errors as text (#3825)
1 parent ff749b8 commit 0665249

2 files changed

Lines changed: 39 additions & 1 deletion

File tree

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
// @vitest-environment jsdom
2+
import pageHtml from "../index.html?raw";
3+
import { expect, it, vi } from "vitest";
4+
5+
vi.mock("@hyperframes/sdk", () => ({ openComposition: vi.fn() }));
6+
vi.mock("@hyperframes/core/gsap-parser-acorn", () => ({ parseGsapScriptAcorn: vi.fn() }));
7+
vi.mock("gsap/dist/gsap.min.js?raw", () => ({ default: "" }));
8+
vi.mock("./fileAdapter.js", () => ({
9+
createFileAdapter: () => Promise.reject(new Error('<img src=x onerror="alert(1)"> & failed')),
10+
}));
11+
12+
it("shows initialization errors as literal text without creating attacker markup", async () => {
13+
document.documentElement.innerHTML = pageHtml;
14+
vi.stubGlobal(
15+
"ResizeObserver",
16+
class {
17+
observe() {}
18+
},
19+
);
20+
const listeners = vi.spyOn(window, "addEventListener");
21+
try {
22+
await import("./main.js");
23+
await vi.waitFor(() => expect(document.querySelector("pre")).not.toBeNull());
24+
expect(document.body.textContent).toBe('Error: <img src=x onerror="alert(1)"> & failed');
25+
expect(document.body.querySelector("img")).toBeNull();
26+
expect(document.body.children).toHaveLength(1);
27+
expect(document.querySelector("pre")?.style.padding).toBe("20px");
28+
} finally {
29+
for (const [type, listener] of listeners.mock.calls) window.removeEventListener(type, listener);
30+
listeners.mockRestore();
31+
vi.unstubAllGlobals();
32+
document.documentElement.innerHTML = "";
33+
}
34+
});

‎packages/sdk-playground/src/main.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1466,5 +1466,9 @@ async function init() {
14661466
}
14671467

14681468
init().catch((err) => {
1469-
document.body.innerHTML = `<pre style="color:#f87171;padding:20px">${String(err)}</pre>`;
1469+
const message = document.createElement("pre");
1470+
message.style.color = "#f87171";
1471+
message.style.padding = "20px";
1472+
message.textContent = String(err);
1473+
document.body.replaceChildren(message);
14701474
});

0 commit comments

Comments
 (0)