Skip to content

refactor: remove symbolRegister function - #4078

Merged
mrlubos merged 1 commit into
mainfrom
refactor/shared-plugin-interface
Jun 17, 2026
Merged

refactor: remove symbolRegister function#4078
mrlubos merged 1 commit into
mainfrom
refactor/shared-plugin-interface

Conversation

@mrlubos

@mrlubos mrlubos commented Jun 17, 2026

Copy link
Copy Markdown
Member

No description provided.

@bolt-new-by-stackblitz

bolt-new-by-stackblitz Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos
mrlubos marked this pull request as ready for review June 17, 2026 09:13
@pullfrog

pullfrog Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Checkout PR refactor: remove symbolRegister function #4078
  • Triage — understand what the PR changes and why
  • Lens decision — determine if parallel review lenses are needed
  • Aggregate findings and draft review
  • Submit review via pullfrog_create_pull_request_review

Pullfrog  ｜ View workflow run ｜ via Pullfrog ｜ Using DeepSeek Pro (free via Pullfrog for OSS) ｜ 𝕏

@vercel

vercel Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 17, 2026 9:15am

Request Review

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. internal ⚙️ Internal development work. labels Jun 17, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jun 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

@hey-api/codegen-core

npm i https://pkg.pr.new/@hey-api/codegen-core@4078

@hey-api/json-schema-ref-parser

npm i https://pkg.pr.new/@hey-api/json-schema-ref-parser@4078

@hey-api/nuxt

npm i https://pkg.pr.new/@hey-api/nuxt@4078

@hey-api/openapi-ts

npm i https://pkg.pr.new/@hey-api/openapi-ts@4078

@hey-api/shared

npm i https://pkg.pr.new/@hey-api/shared@4078

@hey-api/spec-types

npm i https://pkg.pr.new/@hey-api/spec-types@4078

@hey-api/types

npm i https://pkg.pr.new/@hey-api/types@4078

@hey-api/vite-plugin

npm i https://pkg.pr.new/@hey-api/vite-plugin@4078

commit: 4ee65d5

@mrlubos
mrlubos merged commit e3ae288 into main Jun 17, 2026
10 checks passed
@mrlubos
mrlubos deleted the refactor/shared-plugin-interface branch June 17, 2026 09:18
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 17.33333% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.79%. Comparing base (9f539eb) to head (4ee65d5).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/plugins/valibot/v1/api.ts 0.00% 7 Missing ⚠️
...ckages/openapi-ts/src/plugins/zod/shared/export.ts 0.00% 4 Missing and 3 partials ⚠️
packages/openapi-ts/src/plugins/zod/contracts.ts 14.28% 6 Missing ⚠️
packages/openapi-ts/src/plugins/zod/mini/api.ts 0.00% 5 Missing ⚠️
packages/openapi-ts/src/contracts/schema.ts 0.00% 4 Missing ⚠️
packages/openapi-ts/src/plugins/zod/v3/api.ts 0.00% 4 Missing ⚠️
packages/openapi-ts/src/plugins/zod/v4/api.ts 0.00% 4 Missing ⚠️
...-ts/src/plugins/@hey-api/typescript/shared/enum.ts 0.00% 3 Missing ⚠️
...ckages/shared/src/plugins/shared/utils/instance.ts 66.66% 3 Missing ⚠️
...rc/plugins/@hey-api/typescript/shared/operation.ts 60.00% 2 Missing ⚠️
... and 15 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4078      +/-   ##
==========================================
+ Coverage   38.78%   38.79%   +0.01%     
==========================================
  Files         627      630       +3     
  Lines       21897    21907      +10     
  Branches     6408     6415       +7     
==========================================
+ Hits         8492     8499       +7     
- Misses      10921    10927       +6     
+ Partials     2484     2481       -3
Flag Coverage Δ
unittests 38.79% <17.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hey-api hey-api Bot mentioned this pull request Jun 17, 2026
Merged

This branch was successfully deployed

1 active deployment
Preview — 4ee65d52 Deployed Jun 17, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal ⚙️ Internal development work. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mrlubos