Skip to content

docs: add todo comments - #4067

Merged
mrlubos merged 1 commit into
mainfrom
feat/plugin-symbol-meta-4
Jun 15, 2026
Merged

mrlubos merged 1 commit into
mainfrom
feat/plugin-symbol-meta-4

Conversation

@mrlubos

@mrlubos mrlubos commented Jun 15, 2026

Copy link
Copy Markdown
Member

No description provided.

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos
mrlubos marked this pull request as ready for review June 15, 2026 10:07
@vercel

vercel Bot commented Jun 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 15, 2026 10:20am

Request Review

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 15, 2026
@changeset-bot

changeset-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 897e590

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hey-api/shared Minor
@hey-api/openapi-python Patch
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot Bot added the docs 📃 Documentation updates. label Jun 15, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — adds // TODO: contract (…) annotations to symbol lookups and reference calls across 50 plugin files, removes the querySymbols() wrapper from PluginInstance, fixes a few useType → use-type import paths, and adds a changeset for the breaking change.

  • Add // TODO: contract comments — annotates querySymbol, referenceSymbol, and isSymbolRegistered call sites with contract hints (self, cross, ?) across all plugin packages.
  • Remove querySymbols() from PluginInstance — the public wrapper is removed; the single internal call site in .symbolIfNotExists() now calls this.symbolFactory.queryAll() directly.
  • Fix import paths — ./shared/useType → ./shared/use-type in several @tanstack/query-core v5 files.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) | 𝕏

@pkg-pr-new

pkg-pr-new Bot commented Jun 15, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@hey-api/codegen-core

npm i https://pkg.pr.new/@hey-api/codegen-core@4067

@hey-api/json-schema-ref-parser

npm i https://pkg.pr.new/@hey-api/json-schema-ref-parser@4067

@hey-api/nuxt

npm i https://pkg.pr.new/@hey-api/nuxt@4067

@hey-api/openapi-ts

npm i https://pkg.pr.new/@hey-api/openapi-ts@4067

@hey-api/shared

npm i https://pkg.pr.new/@hey-api/shared@4067

@hey-api/spec-types

npm i https://pkg.pr.new/@hey-api/spec-types@4067

@hey-api/types

npm i https://pkg.pr.new/@hey-api/types@4067

@hey-api/vite-plugin

npm i https://pkg.pr.new/@hey-api/vite-plugin@4067

commit: 4d49551

@codecov

codecov Bot commented Jun 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.68%. Comparing base (1d94c48) to head (4d49551).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4067      +/-   ##
==========================================
- Coverage   38.68%   38.68%   -0.01%     
==========================================
  Files         626      626              
  Lines       21865    21864       -1     
  Branches     6406     6406              
==========================================
- Hits         8459     8458       -1     
  Misses      10922    10922              
  Partials     2484     2484              
Flag Coverage Δ
unittests 38.68% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos
mrlubos force-pushed the feat/plugin-symbol-meta-4 branch from 897e590 to 4d49551 Compare June 15, 2026 10:18
@mrlubos
mrlubos merged commit 795a33d into main Jun 15, 2026
10 checks passed
@mrlubos
mrlubos deleted the feat/plugin-symbol-meta-4 branch June 15, 2026 10:23
@hey-api hey-api Bot mentioned this pull request Jun 15, 2026

This branch was successfully deployed

1 active deployment
Preview — 4d495516 Deployed Jun 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs 📃 Documentation updates. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant