Skip to content

refactor: rename symbols to imports - #4052

Merged
mrlubos merged 1 commit into
mainfrom
feat/plugin-symbol-meta-2
Jun 14, 2026
Merged

mrlubos merged 1 commit into
mainfrom
feat/plugin-symbol-meta-2

Conversation

@mrlubos

@mrlubos mrlubos commented Jun 14, 2026

Copy link
Copy Markdown
Member

No description provided.

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos
mrlubos marked this pull request as ready for review June 14, 2026 23:21
@changeset-bot

changeset-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 57fac5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hey-api/openapi-ts Minor
@hey-api/shared Minor
@hey-api/openapi-python Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 14, 2026 11:22pm

Request Review

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. internal ⚙️ Internal development work. labels Jun 14, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jun 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

@hey-api/codegen-core

npm i https://pkg.pr.new/@hey-api/codegen-core@4052

@hey-api/json-schema-ref-parser

npm i https://pkg.pr.new/@hey-api/json-schema-ref-parser@4052

@hey-api/nuxt

npm i https://pkg.pr.new/@hey-api/nuxt@4052

@hey-api/openapi-ts

npm i https://pkg.pr.new/@hey-api/openapi-ts@4052

@hey-api/shared

npm i https://pkg.pr.new/@hey-api/shared@4052

@hey-api/spec-types

npm i https://pkg.pr.new/@hey-api/spec-types@4052

@hey-api/types

npm i https://pkg.pr.new/@hey-api/types@4052

@hey-api/vite-plugin

npm i https://pkg.pr.new/@hey-api/vite-plugin@4052

commit: 57fac5e

@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 4.59184% with 187 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.73%. Comparing base (d606914) to head (57fac5e).

Files with missing lines Patch % Lines
...es/openapi-ts/src/plugins/zod/mini/toAst/string.ts 0.00% 7 Missing ⚠️
.../openapi-ts/src/plugins/valibot/v1/toAst/string.ts 0.00% 6 Missing ⚠️
...es/openapi-ts/src/plugins/zod/mini/toAst/number.ts 0.00% 5 Missing ⚠️
...s/openapi-ts/src/plugins/@pinia/colada/queryKey.ts 0.00% 4 Missing ⚠️
...s/openapi-ts/src/plugins/valibot/v1/toAst/array.ts 0.00% 4 Missing ⚠️
.../openapi-ts/src/plugins/valibot/v1/toAst/number.ts 0.00% 4 Missing ⚠️
...ges/openapi-ts/src/plugins/zod/mini/toAst/array.ts 0.00% 4 Missing ⚠️
...pi-ts/src/plugins/@hey-api/sdk/shared/operation.ts 40.00% 3 Missing ⚠️
packages/openapi-ts/src/plugins/fastify/imports.ts 0.00% 3 Missing ⚠️
...es/openapi-ts/src/plugins/valibot/v1/toAst/enum.ts 0.00% 3 Missing ⚠️
... and 82 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4052      +/-   ##
==========================================
+ Coverage   38.71%   38.73%   +0.02%     
==========================================
  Files         626      626              
  Lines       21892    21878      -14     
  Branches     6408     6407       -1     
==========================================
- Hits         8475     8474       -1     
+ Misses      10933    10920      -13     
  Partials     2484     2484              
Flag Coverage Δ
unittests 38.73% <4.59%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Clean rename, two rough edges worth a look.

Reviewed changes — renames the plugin symbols concept to imports across the entire codebase, removes the external() shorthand from SymbolFactory, and updates all documentation and type definitions.

  • Rename PluginSymbols → PluginImports in shared types (packages/shared/src/plugins/types.ts)
  • Rename symbols → imports on PluginInstance and Plugin.Config (packages/shared/src/plugins/shared/utils/instance.ts)
  • Remove external() method from SymbolFactory (packages/shared/src/utils/symbols.ts) — everything now uses the imports API
  • Rename symbols.ts → imports.ts in all plugin packages with corresponding function/type renames; plugin.symbol() calls in imports functions replaced with factory.register()
  • Update .changeset/ entries documenting the breaking changes across @hey-api/openapi-ts and @hey-api/shared
  • Update docs in migration guide and custom plugin guide (web/src/content/docs/)
  • Fix unrelated formatCompact rounding in web/src/utils/npm.ts

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) | 𝕏

Comment thread web/src/utils/npm.ts Resolved
Comment thread packages/shared/src/utils/symbols.ts Resolved
@mrlubos
mrlubos merged commit 82705ab into main Jun 14, 2026
11 of 12 checks passed
@mrlubos
mrlubos deleted the feat/plugin-symbol-meta-2 branch June 14, 2026 23:38
@hey-api hey-api Bot mentioned this pull request Jun 14, 2026

This branch was successfully deployed

1 active deployment
Preview — 57fac5ef Deployed Jun 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal ⚙️ Internal development work. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant