fix: invalid type for load balancer private network property#372
Merged
jooola merged 1 commit intohetznercloud:mainfrom Mar 27, 2024
Merged
fix: invalid type for load balancer private network property#372jooola merged 1 commit intohetznercloud:mainfrom
jooola merged 1 commit intohetznercloud:mainfrom
Conversation
jooola
force-pushed
the
lb-private-net-types
branch
from
d64ad05 to
310d3c7
Compare
jooola
force-pushed
the
lb-private-net-types
branch
from
310d3c7 to
5c39805
Compare
apricote
approved these changes
Mar 27, 2024
Member
apricote
left a comment
apricote
left a comment
There was a problem hiding this comment.
I assume this is a "bug fix" (rather than breaking change) because only the typing was wrong, while the actual field always contained a list?
Member
Author
|
Yes, this should not be a breaking change, only the type checker might fail, but I think this is "ok". |
apricote
approved these changes
Mar 27, 2024
Member
apricote
left a comment
apricote
left a comment
There was a problem hiding this comment.
Fine by me, any code relying on this typing is "broken" in effect anyway.
jooola
pushed a commit
that referenced
this pull request
Mar 27, 2024
🤖 I have created a release *beep* *boop* --- ## [1.33.3](v1.33.2...v1.33.3) (2024-03-27) ### Bug Fixes * invalid type for load balancer private network property ([#372](#372)) ([903e92f](903e92f)) ### Dependencies * update codecov/codecov-action action to v4 ([#359](#359)) ([a798979](a798979)) * update dependency mypy to >=1.9,<1.10 ([#368](#368)) ([4b9328c](4b9328c)) * update dependency pylint to >=3,<3.2 ([#364](#364)) ([d71d17f](d71d17f)) * update dependency pytest to >=8,<8.2 ([#366](#366)) ([8665dcf](8665dcf)) * update dependency pytest to v8 ([#357](#357)) ([f8f756f](f8f756f)) * update dependency pytest-cov to v5 ([#371](#371)) ([04a6a42](04a6a42)) * update dependency watchdog to v4 ([#360](#360)) ([cb8d383](cb8d383)) * update pre-commit hook asottile/pyupgrade to v3.15.1 ([#362](#362)) ([dd2a521](dd2a521)) * update pre-commit hook asottile/pyupgrade to v3.15.2 ([3d02ad7](3d02ad7)) * update pre-commit hook psf/black-pre-commit-mirror to v24 ([#356](#356)) ([b46397d](b46397d)) * update pre-commit hook psf/black-pre-commit-mirror to v24.1.1 ([#358](#358)) ([7e4645e](7e4645e)) * update pre-commit hook psf/black-pre-commit-mirror to v24.2.0 ([#361](#361)) ([5b56ace](5b56ace)) * update pre-commit hook psf/black-pre-commit-mirror to v24.3.0 ([3bbac5d](3bbac5d)) * update pre-commit hook pycqa/flake8 to v7 ([#354](#354)) ([66a582f](66a582f)) * update pypa/gh-action-pypi-publish action to v1.8.12 ([#365](#365)) ([55db255](55db255)) * update pypa/gh-action-pypi-publish action to v1.8.14 ([#367](#367)) ([0cb615f](0cb615f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.hetzner.cloud/#load-balancers-get-a-load-balancer