fix: do not ignore action error when the error message is empty#801
Merged
fix: do not ignore action error when the error message is empty#801
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
- Coverage 79.42% 79.37% -0.05%
==========================================
Files 60 60
Lines 4553 4558 +5
==========================================
+ Hits 3616 3618 +2
- Misses 634 637 +3
Partials 303 303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phm07
approved these changes
Jan 9, 2026
The action error message is bad to evaluate whether an action has failed. Instead we now check if the status is failed or if the error code is set.
jooola
force-pushed
the
fix-action-error
branch
from
f69abe8 to
e15b1e7
Compare
Member
Author
|
Not sure if we want to set default values for the code and the message, when the API is missing those values. |
apricote
approved these changes
Jan 14, 2026
Member
apricote
left a comment
apricote
left a comment
There was a problem hiding this comment.
The defaults sound good, the <> shows that the value is not coming from the API.
jooola
pushed a commit
that referenced
this pull request
Jan 16, 2026
<!-- section-start changelog --> ### [`StorageBoxClient.GetSubaccount`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#StorageBoxClient.GetSubaccount) no longer gets a subaccount by `username` [`StorageBoxClient.GetSubaccount`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#StorageBoxClient.GetSubaccount) no longer tries to get a subaccount by `username`, instead it tries to get it by `name`. To get a subaccount by `username` please use [`StorageBoxClient.GetSubaccountByUsername`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#StorageBoxClient.GetSubaccountByUsername). See the [changelog](https://docs.hetzner.cloud/changelog#2026-01-15-storage-box-subaccount-name) for more details. ### Features - add name to Storage Box Subaccount (#806) ### Bug Fixes - do not ignore action error when the error message is empty (#801) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ~~~~rp-prefix ### [`StorageBoxClient.GetSubaccount`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#StorageBoxClient.GetSubaccount) no longer gets a subaccount by `username` [`StorageBoxClient.GetSubaccount`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#StorageBoxClient.GetSubaccount) no longer tries to get a subaccount by `username`, instead it tries to get it by `name`. To get a subaccount by `username` please use [`StorageBoxClient.GetSubaccountByUsername`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#StorageBoxClient.GetSubaccountByUsername). See the [changelog](https://docs.hetzner.cloud/changelog#2026-01-15-storage-box-subaccount-name) for more details. ~~~~ ### Suffix / End This will be added to the end of the release notes. ~~~~rp-suffix ~~~~ </details> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Jan 16, 2026
…5.0 (hetznercloud/fleeting-plugin-hetzner!338) This MR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | `v2.34.0` → `v2.35.0` |  |  | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.35.0`](https://github.com/hetznercloud/hcloud-go/blob/HEAD/CHANGELOG.md#v2350) [Compare Source](hetznercloud/hcloud-go@v2.34.0...v2.35.0) ##### [`StorageBoxClient.GetSubaccount`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#StorageBoxClient.GetSubaccount) no longer gets a subaccount by `username` [`StorageBoxClient.GetSubaccount`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#StorageBoxClient.GetSubaccount) no longer tries to get a subaccount by `username`, instead it tries to get it by `name`. To get a subaccount by `username` please use [`StorageBoxClient.GetSubaccountByUsername`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#StorageBoxClient.GetSubaccountByUsername). See the [changelog](https://docs.hetzner.cloud/changelog#2026-01-15-storage-box-subaccount-name) for more details. ##### Features - add name to Storage Box Subaccount ([#​806](hetznercloud/hcloud-go#806)) ##### Bug Fixes - do not ignore action error when the error message is empty ([#​801](hetznercloud/hcloud-go#801)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44Mi4zIiwidXBkYXRlZEluVmVyIjoiNDIuODIuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action error message should not be used to evaluate if an action has failed. Instead we now check if the action status is failed or if the error code is set.