feat: default to max per page value in AllWithOpts#794
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 80.05% 80.00% -0.05%
==========================================
Files 60 60
Lines 4452 4492 +40
==========================================
+ Hits 3564 3594 +30
- Misses 587 596 +9
- Partials 301 302 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phm07
left a comment
There was a problem hiding this comment.
Maybe something like const MaxItemsPerPage = 50 and then using that constant instead would be nice to eliminate the magic number. But works without that as well
While we use 50 almost everywhere, it is not the true max for all list endpoints, e.g. zone rrsets allow per_page=100. So we could use one, but it must be private. |
<!-- section-start changelog --> ### Features - add update rrset records action to zone client (#773) - deprecate datacenter in `primary ips` and `servers` (#793) - default to max per page value in `AllWithOpts` (#794) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ~~~~rp-prefix ~~~~ ### Suffix / End This will be added to the end of the release notes. ~~~~rp-suffix ~~~~ </details> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…3.0 (hetznercloud/fleeting-plugin-hetzner!322) This MR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | `v2.32.0` → `v2.33.0` |  |  | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.33.0`](https://github.com/hetznercloud/hcloud-go/blob/HEAD/CHANGELOG.md#v2330) [Compare Source](hetznercloud/hcloud-go@v2.32.0...v2.33.0) ##### Features - add update rrset records action to zone client ([#​773](hetznercloud/hcloud-go#773)) - deprecate datacenter in `primary ips` and `servers` ([#​793](hetznercloud/hcloud-go#793)) - default to max per page value in `AllWithOpts` ([#​794](hetznercloud/hcloud-go#794)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi42NC4xIiwidXBkYXRlZEluVmVyIjoiNDIuNjQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Fixes #792