Skip to content

Comments

fix: storage boxes fixes#752

Merged
jooola merged 19 commits intostorage-boxesfrom
sbx-more-fixes
Oct 17, 2025
Merged

fix: storage boxes fixes#752
jooola merged 19 commits intostorage-boxesfrom
sbx-more-fixes

Conversation

@jooola
Copy link
Member

@jooola jooola commented Oct 17, 2025

Additional fixes for the storage boxes implementation.

@jooola jooola requested a review from a team as a code owner October 17, 2025 11:21
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.56%. Comparing base (bf3ac97) to head (92ff8fc).
⚠️ Report is 1 commits behind head on storage-boxes.

Files with missing lines Patch % Lines
hcloud/storage_box_snapshot.go 57.14% 2 Missing and 1 partial ⚠️
hcloud/storage_box.go 85.71% 1 Missing ⚠️
hcloud/storage_box_subaccount.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           storage-boxes     #752      +/-   ##
=================================================
- Coverage          78.57%   78.56%   -0.01%     
=================================================
  Files                 59       59              
  Lines               5591     5603      +12     
=================================================
+ Hits                4393     4402       +9     
- Misses               907      909       +2     
- Partials             291      292       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jooola jooola marked this pull request as draft October 17, 2025 11:24
@jooola jooola requested review from lukasmetzner and phm07 October 17, 2025 12:46
@jooola jooola marked this pull request as ready for review October 17, 2025 12:46
@jooola
Copy link
Member Author

jooola commented Oct 17, 2025

This is ready to be reviewed. Reviewing one commit at the time is probably easier.

@jooola jooola merged commit be9038e into storage-boxes Oct 17, 2025
3 checks passed
@jooola jooola deleted the sbx-more-fixes branch October 17, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants