fix: subresources contain parent#719
Merged
lukasmetzner merged 1 commit intostorage-boxesfrom Sep 8, 2025
Merged
Conversation
`hcloud.StorageBox` is part of `hcloud.StorageBoxSubaccount` and `hcloud.StorageBoxSnapshot`. Therefore, we can remove the storage box reference from the function parameters.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## storage-boxes #719 +/- ##
=================================================
- Coverage 79.18% 79.07% -0.11%
=================================================
Files 54 54
Lines 4952 4952
=================================================
- Hits 3921 3916 -5
- Misses 793 796 +3
- Partials 238 240 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phm07
approved these changes
Sep 8, 2025
phm07
pushed a commit
that referenced
this pull request
Sep 19, 2025
`hcloud.StorageBox` is part of `hcloud.StorageBoxSubaccount` and `hcloud.StorageBoxSnapshot`. Therefore, we can remove the storage box reference from the function parameters.
lukasmetzner
added a commit
that referenced
this pull request
Oct 9, 2025
`hcloud.StorageBox` is part of `hcloud.StorageBoxSubaccount` and `hcloud.StorageBoxSnapshot`. Therefore, we can remove the storage box reference from the function parameters.
jooola
pushed a commit
that referenced
this pull request
Oct 17, 2025
`hcloud.StorageBox` is part of `hcloud.StorageBoxSubaccount` and `hcloud.StorageBoxSnapshot`. Therefore, we can remove the storage box reference from the function parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hcloud.StorageBoxis part ofhcloud.StorageBoxSubaccountandhcloud.StorageBoxSnapshot. Therefore, we can remove the storage box reference from the function parameters.