Skip to content

Comments

feat: add support for Storage Box Types#687

Merged
lukasmetzner merged 8 commits intostorage-boxesfrom
storage-boxes-feat-storage-box-types
Aug 18, 2025
Merged

feat: add support for Storage Box Types#687
lukasmetzner merged 8 commits intostorage-boxesfrom
storage-boxes-feat-storage-box-types

Conversation

@lukasmetzner
Copy link
Contributor

@lukasmetzner lukasmetzner requested a review from a team as a code owner August 6, 2025 09:23
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 82.25806% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.26%. Comparing base (81a5117) to head (cdcb43b).
⚠️ Report is 1 commits behind head on storage-boxes.

Files with missing lines Patch % Lines
hcloud/storage_box_type.go 80.43% 8 Missing and 1 partial ⚠️
hcloud/schema.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           storage-boxes     #687      +/-   ##
=================================================
+ Coverage          79.14%   79.26%   +0.12%     
=================================================
  Files                 50       51       +1     
  Lines               4426     4481      +55     
=================================================
+ Hits                3503     3552      +49     
- Misses               706      713       +7     
+ Partials             217      216       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apricote apricote force-pushed the storage-boxes-feat-storage-box-types branch from e2ecb50 to 003803d Compare August 8, 2025 07:52
@apricote apricote force-pushed the storage-boxes-feat-storage-box-types branch from 003803d to b37ec47 Compare August 8, 2025 07:57
@apricote
Copy link
Member

apricote commented Aug 8, 2025

I added GetByName() and Get(). PR is feature complete.

@jooola I accidentally force-pushed on outdated commit inbetween, but you can check out the diff to Lukas last push here: https://github.com/hetznercloud/hcloud-go/compare/e2ecb508ae25bb151a1b590955c8a115f2265297..b37ec47440b9a3b4c356db0af0db35ab2dc68195

Realized this while adding it to CLI
@apricote apricote force-pushed the storage-boxes-feat-storage-box-types branch from ea92df1 to cdcb43b Compare August 8, 2025 08:46
@lukasmetzner lukasmetzner merged commit 9f91d13 into storage-boxes Aug 18, 2025
3 checks passed
@lukasmetzner lukasmetzner deleted the storage-boxes-feat-storage-box-types branch August 18, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants