Fix typo in command to log pip-diff failure#832
Merged
CaseyFaist merged 1 commit intoheroku:masterfrom Sep 30, 2019
Merged
Conversation
cjolowicz
force-pushed
the
fix-mcount-typo
branch
from
f0d0f57 to
12494e8
Compare
Author
|
It appears that Travis CI is broken for external pull requests because the environment variables /home/travis/build/heroku/heroku-buildpack-python/vendor/bundle/ruby/2.4.0/gems/heroku_hatchet-4.0.6/etc/ci_setup.rb:10:
in `fetch': key not found: "HEROKU_API_USER" (KeyError)You can see the same changes actually passing CI in this PR in my fork: This PR is based against my fork, with I would like to contribute some other changes (see cjolowicz#13 and cjolowicz#14), so I'm wondering how to best make PRs for this repository. |
Closed
Author
|
Here is an example for when this bug is hit. Traceback (most recent call last):
File "/app/.heroku/python/lib/python3.7/site-packages/pip/_internal/download.py", line 665, in get_file_content
with open(url, 'rb') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'requirements/base.txt'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/tmp/buildpacks/33e977e2b813adb8f433f2a7adcfb3ddb2a56e566732d9bbea567c8a3d9f23de56cc92a95c5eceecf6c023272911ba623f1932889b0b52ecd7f577446edfa659/vendor/pip-pop/pip-diff", line 132, in <module>
main()
File "/app/tmp/buildpacks/33e977e2b813adb8f433f2a7adcfb3ddb2a56e566732d9bbea567c8a3d9f23de56cc92a95c5eceecf6c023272911ba623f1932889b0b52ecd7f577446edfa659/vendor/pip-pop/pip-diff", line 128, in main
diff(**kwargs)
File "/app/tmp/buildpacks/33e977e2b813adb8f433f2a7adcfb3ddb2a56e566732d9bbea567c8a3d9f23de56cc92a95c5eceecf6c023272911ba623f1932889b0b52ecd7f577446edfa659/vendor/pip-pop/pip-diff", line 100, in diff
r1 = Requirements(r1)
File "/app/tmp/buildpacks/33e977e2b813adb8f433f2a7adcfb3ddb2a56e566732d9bbea567c8a3d9f23de56cc92a95c5eceecf6c023272911ba623f1932889b0b52ecd7f577446edfa659/vendor/pip-pop/pip-diff", line 44, in __init__
self.load(reqfile)
File "/app/tmp/buildpacks/33e977e2b813adb8f433f2a7adcfb3ddb2a56e566732d9bbea567c8a3d9f23de56cc92a95c5eceecf6c023272911ba623f1932889b0b52ecd7f577446edfa659/vendor/pip-pop/pip-diff", line 54, in load
for requirement in parse_requirements(reqfile, finder=finder, session=requests):
File "/app/.heroku/python/lib/python3.7/site-packages/pip/_internal/req/req_file.py", line 113, in parse_requirements
for req in req_iter:
File "/app/.heroku/python/lib/python3.7/site-packages/pip/_internal/req/req_file.py", line 233, in process_line
for req in parsed_reqs:
File "/app/.heroku/python/lib/python3.7/site-packages/pip/_internal/req/req_file.py", line 104, in parse_requirements
filename, comes_from=comes_from, session=session
File "/app/.heroku/python/lib/python3.7/site-packages/pip/_internal/download.py", line 669, in get_file_content
'Could not open requirements file: %s' % str(exc)
pip._internal.exceptions.InstallationError: Could not open requirements file: [Errno 2] No such file or directory: 'requirements/base.txt'
mount: failure.bad-requirements: No such file or directory |
cjolowicz
force-pushed
the
fix-mcount-typo
branch
from
12494e8 to
ecb9ab4
Compare
jkutner
approved these changes
Sep 24, 2019
hone
approved these changes
Sep 24, 2019
The pip-diff tool from vendor/pip-pop is used to determine stale requirements. When pip-diff encounters an unexpected failure, a count is logged using mcount from heroku/buildpack-stdlib. Due to a typo, mount(8) was invoked instead of mcount, with an invalid argument.
cjolowicz
force-pushed
the
fix-mcount-typo
branch
from
ecb9ab4 to
0c701de
Compare
Author
|
Rebased onto master ( |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a typo,
mount(8)is invoked instead ofmcountfrom heroku/buildpack-stdlib.The
pip-difftool fromvendor/pip-popis used to determine stale requirements. Whenpip-diffencounters an unexpected failure, a count should be logged usingmcount.