Stop installing pip into Poetry's virtual environment#1761
Merged
Conversation
This is an alternative approach to installing Poetry that means we can skip installing pip into its virtual environment, but still support the outdated Python versions which bundle older pip (that don't support the `--python` option; see #1687) or that don't correctly isolate the environment when running `ensurepip` (see #1698). Skipping installing pip speeds up the cold cache build for Poetry slightly, and also reduces the build cache size (which will help with the cache save and restore times for warm builds too). The pip installed in the Poetry venv wasn't exposed to apps (since it wasn't on `PATH`) so is safe to remove. GUS-W-17895154.
Malax
approved these changes
Feb 24, 2025
Merged
edmorley
added a commit
that referenced
this pull request
Oct 15, 2025
Since: - The underlying cause of the errors (a bug in older `ensurepip`) was fixed in #1761 and friends. - As of #1933 the generic error trap now handles all internal errors, meaning we don't custom handling for them any more. GUS-W-19898848.
edmorley
added a commit
that referenced
this pull request
Oct 15, 2025
Since: - The underlying cause of the errors (a bug in older `ensurepip`) was fixed in #1761 and friends. - As of #1933 the generic error trap now handles all internal errors, meaning we don't custom handling for them any more. GUS-W-19898848.
edmorley
added a commit
that referenced
this pull request
Oct 15, 2025
Since: - The underlying cause of the errors (a bug in older `ensurepip`) was fixed in #1761 and friends. - As of #1933 the generic error trap now handles all internal errors, meaning we don't custom handling for them any more. GUS-W-19898848.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to installing Poetry that means we can skip installing pip into its virtual environment, but still support the outdated Python versions which bundle older pip (that don't support the
--pythonoption; see #1687) or that don't correctly isolate the environment when runningensurepip(see #1698).Skipping installing pip speeds up the cold cache build for Poetry slightly, and also reduces the build cache size (which will help with the cache save and restore times for warm builds too).
The pip installed in the Poetry venv wasn't exposed to apps (since it wasn't on
PATH) so is safe to remove.GUS-W-17895154.