Vendor Ruby if an installation is not found #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ERB templating feature of this buildpack requires that the `erb` command (part of Ruby) be available at runtime, in order that the nginx config templates can be rendered into a valid nginx config. On Heroku-22 the stack image no longer includes a system Ruby installation, so in order for this buildpack to continue to work, a Ruby install must be vendored by this buildpack. If an app already uses the Ruby buildpack, and that buildpack is ordered prior to the nginx buildpack, then this buildpack will skip the Ruby vendoring step to save installing a redundant copy of Ruby. Fixes #101. GUS-W-11321729.
|
Tested on Heroku-22 and seems to work fine: |
|
In terms of impact on slug size, the uncompressed size of the Ruby install is 48MB: However the 500MB slug size limit applies to the compressed size, for which the increase is only 20.9 MB on Heroku-22: Before: After: These slug size increases seem very acceptable, in return for the benefits of no longer having Ruby in the stack image - for which there are more details in: |
|
And confirmed the vendored Ruby isn't installed on stacks where system Ruby is present: |
Malax
approved these changes
Jun 21, 2022
|
Published: |
This was referenced Jun 26, 2022
targess
pushed a commit
to kelkoo-services/heroku-buildpack-nginx
that referenced
this pull request
Jan 7, 2025
The ERB templating feature of this buildpack requires that the `erb` command (part of Ruby) be available at runtime, in order that the nginx config templates can be rendered into a valid nginx config. On Heroku-22 the stack image no longer includes a system Ruby installation, so in order for this buildpack to continue to work, a Ruby install must be vendored by this buildpack. If an app already uses the Ruby buildpack, and that buildpack is ordered prior to the nginx buildpack, then this buildpack will skip the Ruby vendoring step to save installing a redundant copy of Ruby. Fixes heroku#101. GUS-W-11321729.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ERB templating feature of this buildpack requires that the
erbcommand (part of Ruby) be available at runtime, in order that the nginx config templates can be rendered into a valid nginx config.On Heroku-22 the stack image no longer includes a system Ruby installation, so in order for this buildpack to continue to work, a Ruby install must be vendored by this buildpack.
If an app already uses the Ruby buildpack, and that buildpack is ordered prior to the nginx buildpack, then this buildpack will skip the Ruby vendoring step to save installing a redundant copy of Ruby.
Fixes #101.
GUS-W-11321729.