Conversation
|
Huge 👍 |
|
I don't think we should encourage forking a deprecated buildpack. |
dzuelke
changed the title
|
Deprecation notice added and README updated accordingly. |
There was a problem hiding this comment.
I'm not sure you can add this line when our buildpack is a fork too.
There was a problem hiding this comment.
I was wondering the same, but given how the original author was a Heroku employee at that time, I figured it'd just be a clarification, not a change?!
There was a problem hiding this comment.
Some contributors are not, though. I think it's easier to just remove that commit. It doesn't make much of a difference if we're going to deprecate it.
|
👍 |
|
Looks good to me. |
|
@dzuelke lgtm. may i merge? |
|
Go ahead!
|
|
FYI, this buildpack may be still useful for a kernel app. /cc @mikehale |
|
Yeah we're just deprecating, not removing anytime soon (and most people are likely running off ddollar's repo anyway). |
7 participants
That way the list of buildpacks gets exposed through the API, so it's easily visible to customers, support etc.