Conversation
Contributor
schneems
commented
Nov 13, 2020
Remove all warnings ``` shellcheck -x bin/build bin/compile bin/detect bin/release bin/support/bash_functions.sh ⛄ 2.7.2 🚀 ~/Documents/projects/work/minimal-ruby (schneems/shellcheck) $ echo $? 0 ```
d0b8c1d to
9d897e9
Compare
The java buildpack exports this file: ``` export JAVA_HOME=/tmp/build_c6a36294/.jdk export PATH=$JAVA_HOME/bin:$PATH export LD_LIBRARY_PATH="$JAVA_HOME/jre/lib/amd64/server:$LD_LIBRARY_PATH" ``` Which raises this error when sourcing with strict mode on: ``` line 3: LD_LIBRARY_PATH: unbound variable ``` The solution from http://redsymbol.net/articles/unofficial-bash-strict-mode/#sourcing-nonconforming-document and @edmorley is to reduce the checking level before sourcing and then to increase it after.
Linux does not have a `-s` flag, but Mac does. This instead directs output to `/dev/null` so it doesn't show up in our build output.
9d897e9 to
86aa3cf
Compare
86aa3cf to
6be86ae
Compare
405b8a0 to
3ad7e0c
Compare
73b798a to
9f99a88
Compare
9f99a88 to
4b3df95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.