Parse file-based app AssemblyName configuration#359
Merged
runesoerensen merged 4 commits intomainfrom Dec 10, 2025
Merged
Conversation
runesoerensen
changed the base branch from
main
to
improve-launch-process-detection
runesoerensen
changed the title
AssemblyName propertyAssemblyName configuration
runesoerensen
force-pushed
the
parse-file-based-app-assembly-name-property
branch
from
8ca6735 to
1c616b4
Compare
runesoerensen
changed the base branch from
improve-launch-process-detection
to
main
runesoerensen
force-pushed
the
parse-file-based-app-assembly-name-property
branch
from
1c616b4 to
45f3143
Compare
edmorley
approved these changes
Dec 10, 2025
Also verify that both leading and trailing whitespace is trimmed from the parsed preprocessor directive values
runesoerensen
force-pushed
the
parse-file-based-app-assembly-name-property
branch
from
45f3143 to
86bb2b7
Compare
runesoerensen
deleted the
parse-file-based-app-assembly-name-property
branch
heroku-linguist Bot
added a commit
that referenced
this pull request
Dec 11, 2025
## heroku/dotnet ### Added - Support for configuring the target framework using `Directory.Build.props`. ([#362](#362)) - Support for configuring the `AssemblyName` property in file-based apps. ([#359](#359)) ### Fixed - Fixed an issue where leading whitespace in file-based app configuration values was incorrectly included. ([#359](#359))
Merged
heroku-linguist Bot
added a commit
that referenced
this pull request
Dec 13, 2025
## heroku/dotnet ### Added - Support for configuring the target framework using `Directory.Build.props`. ([#362](#362)) - Support for configuring the `AssemblyName` property in file-based apps. ([#359](#359)) ### Fixed - Fixed an issue where leading whitespace in file-based app configuration values was incorrectly included. ([#359](#359))
heroku-linguist Bot
added a commit
that referenced
this pull request
Dec 13, 2025
## heroku/dotnet ### Added - Support for configuring the target framework using `Directory.Build.props`. ([#362](#362)) - Support for configuring the `AssemblyName` property in file-based apps. ([#359](#359)) ### Fixed - Fixed an issue where leading whitespace in file-based app configuration values was incorrectly included. ([#359](#359)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
heroku-linguist Bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Dec 13, 2025
## heroku/dotnet ### Added - Support for configuring the target framework using `Directory.Build.props`. ([#362](heroku/buildpacks-dotnet#362)) - Support for configuring the `AssemblyName` property in file-based apps. ([#359](heroku/buildpacks-dotnet#359)) ### Fixed - Fixed an issue where leading whitespace in file-based app configuration values was incorrectly included. ([#359](heroku/buildpacks-dotnet#359))
heroku-linguist Bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Dec 13, 2025
## heroku/dotnet ### Added - Support for configuring the target framework using `Directory.Build.props`. ([#362](heroku/buildpacks-dotnet#362)) - Support for configuring the `AssemblyName` property in file-based apps. ([#359](heroku/buildpacks-dotnet#359)) ### Fixed - Fixed an issue where leading whitespace in file-based app configuration values was incorrectly included. ([#359](heroku/buildpacks-dotnet#359)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
#:property AssemblyName=directive in file-based apps. Previously, file-based apps always used the filename stem as the assembly name. The assembly name is used when registering launch processes, so using it when defined ensures the buildpack generates the correct launch commands.Also fixes leading whitespace handling for file-based app directives configuring the project SDK and target framework.
GUS-W-20474431
GUS-W-20500386