Skip to content

Use latest stable Docker in GHA workflows#378

Merged
dzuelke merged 1 commit intomainfrom
fix-github-docker-compat
Mar 3, 2026
Merged

Use latest stable Docker in GHA workflows#378
dzuelke merged 1 commit intomainfrom
fix-github-docker-compat

Conversation

@dzuelke
Copy link
Copy Markdown
Contributor

@dzuelke dzuelke commented Mar 3, 2026

We started using on the --platform option of docker image inspect in #374, which is only available in Docker 28.1.0+: docker/cli#5934

GitHub recently reverted the changes announced in actions/runner-images#13474 as they were causing too many regressions for users, so the runners for now are back to Docker 28.0.4: actions/runner-images@8323333

Instead of relying on whatever Docker version the runners ship with, we now fetch the latest stable using docker/setup-docker-action, which will generally reduce our reliance on runner-images-induced regressions like this in the future.

Needs https://github.com/heroku/scm-github-admin/pull/43 to be merged and applied as docker/setup-docker-action is not currently allow-listed.

GUS-W-21410117

@dzuelke dzuelke requested a review from a team as a code owner March 3, 2026 13:28
@edmorley edmorley force-pushed the fix-github-docker-compat branch from f4ae91b to 80dabb8 Compare March 3, 2026 13:56
Comment thread .github/workflows/ci.yml
@dzuelke dzuelke force-pushed the fix-github-docker-compat branch 2 times, most recently from 1dc19ac to 6388c8b Compare March 3, 2026 14:15
We started using on the `--platform` option of `docker image inspect` in #374, which is only available in Docker 28.1.0+: docker/cli#5934

GitHub recently reverted the changes announced in actions/runner-images#13474 as they were causing too many regressions for users, so the runners for now are back to Docker 28.0.4: actions/runner-images@8323333

Instead of relying on whatever Docker version the runners ship with, we now fetch the latest stable using `docker/setup-docker-action`, which will generally reduce our reliance on runner-images-induced regressions like this in the future.

GUS-W-21410117
@dzuelke dzuelke force-pushed the fix-github-docker-compat branch from 99c544c to 2a870db Compare March 3, 2026 14:37
@dzuelke dzuelke enabled auto-merge (squash) March 3, 2026 14:38
Copy link
Copy Markdown
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dzuelke dzuelke merged commit c11b4dc into main Mar 3, 2026
10 checks passed
@dzuelke dzuelke deleted the fix-github-docker-compat branch March 3, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants