-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfiles and scripts for Heroku-22 #209
Conversation
Almost no changes over heroku-20 right now; only bumped libwebp and sorted out a few package versions or name changes (e.g. mime-support to media-types) To discuss: ruby removal, python2 removal, libssl1.1 To do: libpq-dev instead of pg-server-dev, sync ImageMagick policy with upstream GUS-W-10340283
Thank you for opening this! :-)
Yeah I'd like to remove system Ruby from the stack image, since:
Yeah I'm happy to remove Python 2 (or more, not add it back given it's not in there as-is). People who need Python 2 for system Python can use
It seems there isn't a |
Yup agreed on all points @edmorley. I forgot to mention it'll likely be useless to include libssl1.1 for the reason you mentioned; also note that in bionic, you could not install headers for both versions, since the header file paths are identical and the packages thus conflict. |
it is now a dependency of some package at runtime, so add it to the list and include the headers in the build image should probably add this to heroku-20 as well, would be useful
libpq-dev is enough; nobody will be building actual postgres server extensions :) this does, however, also remove LLVM and Clang, which is great for image size, but I suspect we will want to consider adding these back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great thank you!
was MB, should be MP
Almost no changes over heroku-20 right now; only bumped
libwebp
and sorted out a few package versions or name changes (e.g.mime-support
tomedia-types
).Removed
postgresql-server-dev-14
;libpq-dev
is enough since nobody will be building Postgres extensions.libheif1
is now an explicitly installed package, with headers.ImageMagick policy hasn't changed since 20.04.
To discuss:
GUS-W-10340283