|
| 1 | +/* |
| 2 | + Copyright The containerd Authors. |
| 3 | +
|
| 4 | + Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | + you may not use this file except in compliance with the License. |
| 6 | + You may obtain a copy of the License at |
| 7 | +
|
| 8 | + http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | +
|
| 10 | + Unless required by applicable law or agreed to in writing, software |
| 11 | + distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | + See the License for the specific language governing permissions and |
| 14 | + limitations under the License. |
| 15 | +*/ |
| 16 | + |
| 17 | +package integration |
| 18 | + |
| 19 | +import ( |
| 20 | + "bytes" |
| 21 | + "context" |
| 22 | + "fmt" |
| 23 | + "net/url" |
| 24 | + "os/exec" |
| 25 | + "strings" |
| 26 | + "testing" |
| 27 | + "time" |
| 28 | + |
| 29 | + "github.com/containerd/containerd/v2/integration/images" |
| 30 | + "github.com/containerd/containerd/v2/pkg/namespaces" |
| 31 | + "github.com/stretchr/testify/require" |
| 32 | + "k8s.io/client-go/rest" |
| 33 | + remoteclient "k8s.io/client-go/tools/remotecommand" |
| 34 | + criruntime "k8s.io/cri-api/pkg/apis/runtime/v1" |
| 35 | +) |
| 36 | + |
| 37 | +func TestContainerTTYLeakAfterExit(t *testing.T) { |
| 38 | + t.Log("Create a sandbox") |
| 39 | + sb, sbConfig := PodSandboxConfigWithCleanup(t, "sandbox", "container-tty-leak-after-exit") |
| 40 | + |
| 41 | + testImage := images.Get(images.BusyBox) |
| 42 | + EnsureImageExists(t, testImage) |
| 43 | + |
| 44 | + var testcases = []struct { |
| 45 | + name string |
| 46 | + stdin bool |
| 47 | + }{ |
| 48 | + { |
| 49 | + name: "ttyOnly", |
| 50 | + stdin: false, |
| 51 | + }, |
| 52 | + { |
| 53 | + name: "interactive", |
| 54 | + stdin: true, |
| 55 | + }, |
| 56 | + } |
| 57 | + |
| 58 | + for _, testcase := range testcases { |
| 59 | + t.Run(testcase.name, func(t *testing.T) { |
| 60 | + t.Log("Create a container") |
| 61 | + cnConfig := ContainerConfig( |
| 62 | + testcase.name, |
| 63 | + testImage, |
| 64 | + WithCommand("sh", "-c", "sleep 365d"), |
| 65 | + ) |
| 66 | + cnConfig.Stdin = testcase.stdin |
| 67 | + cnConfig.Tty = true |
| 68 | + |
| 69 | + t.Log("Create the container") |
| 70 | + cn, err := runtimeService.CreateContainer(sb, cnConfig, sbConfig) |
| 71 | + require.NoError(t, err) |
| 72 | + |
| 73 | + t.Log("Start the container") |
| 74 | + require.NoError(t, runtimeService.StartContainer(cn)) |
| 75 | + |
| 76 | + pid := getShimPid(t, sb) |
| 77 | + checkTTY(t, pid, 1) |
| 78 | + |
| 79 | + t.Log("Exec in container") |
| 80 | + rsp, err := runtimeService.Exec(&criruntime.ExecRequest{ |
| 81 | + ContainerId: cn, |
| 82 | + Cmd: []string{"sh", "-c", "echo tty"}, |
| 83 | + Stderr: false, |
| 84 | + Stdout: true, |
| 85 | + Stdin: testcase.stdin, |
| 86 | + Tty: true, |
| 87 | + }) |
| 88 | + require.NoError(t, err) |
| 89 | + |
| 90 | + execURL := rsp.Url |
| 91 | + URL, err := url.Parse(execURL) |
| 92 | + require.NoError(t, err) |
| 93 | + |
| 94 | + executor, err := remoteclient.NewSPDYExecutor(&rest.Config{}, "POST", URL) |
| 95 | + require.NoError(t, err) |
| 96 | + |
| 97 | + outBuf := bytes.NewBuffer(make([]byte, 64)) |
| 98 | + streamOptions := remoteclient.StreamOptions{ |
| 99 | + Stdout: outBuf, |
| 100 | + Tty: true, |
| 101 | + } |
| 102 | + if testcase.stdin { |
| 103 | + streamOptions.Stdin = bytes.NewBuffer(nil) |
| 104 | + } |
| 105 | + |
| 106 | + require.NoError(t, executor.StreamWithContext(context.Background(), streamOptions)) |
| 107 | + checkTTY(t, pid, 1) |
| 108 | + |
| 109 | + t.Log("Stop the container") |
| 110 | + require.NoError(t, runtimeService.StopContainer(cn, 10)) |
| 111 | + |
| 112 | + t.Log("Remove the container") |
| 113 | + require.NoError(t, runtimeService.RemoveContainer(cn)) |
| 114 | + |
| 115 | + checkTTY(t, pid, 0) |
| 116 | + }) |
| 117 | + } |
| 118 | + |
| 119 | +} |
| 120 | + |
| 121 | +func getShimPid(t *testing.T, sb string) int { |
| 122 | + ctx := namespaces.WithNamespace(context.Background(), "k8s.io") |
| 123 | + shimCli := connectToShim(ctx, t, containerdEndpoint, 3, sb) |
| 124 | + return int(shimPid(ctx, t, shimCli)) |
| 125 | +} |
| 126 | + |
| 127 | +func numTTY(shimPid int) int { |
| 128 | + cmd := exec.Command("sh", "-c", fmt.Sprintf("lsof -p %d | grep ptmx", shimPid)) |
| 129 | + var stdout bytes.Buffer |
| 130 | + cmd.Stdout = &stdout |
| 131 | + if err := cmd.Run(); err != nil { |
| 132 | + return 0 |
| 133 | + } |
| 134 | + return strings.Count(stdout.String(), "\n") |
| 135 | +} |
| 136 | + |
| 137 | +func checkTTY(t *testing.T, shimPid, expected int) { |
| 138 | + require.NoError(t, Eventually(func() (bool, error) { |
| 139 | + if numTTY(shimPid) == expected { |
| 140 | + return true, nil |
| 141 | + } |
| 142 | + return false, nil |
| 143 | + }, time.Second, 30*time.Second)) |
| 144 | +} |
0 commit comments