Allow set of namespace in environment and helmDefaults#947
Conversation
wrenix
requested review from
itscaro,
mumoshu,
xiaomudk and
yxxhero
as code owners
wrenix
force-pushed
the
patch-1
branch
4 times, most recently
from
3f15484 to
3d7145e
Compare
| # See the helm usage (helm SUBCOMMAND -h) for more info on default values when those flags aren't provided. | ||
| helmDefaults: | ||
| kubeContext: kube-context #dedicated default key for kube-context (--kube-context) | ||
| namespace: default #dedicated default key for namespace (--namespace) |
There was a problem hiding this comment.
I think the default value shouldn't always be default.
It should be actually omitted by default.
When omitted, the namespace set in the kube-context will be used.
In case no namespace is set in the context, then default is used.
There was a problem hiding this comment.
your are correct, so in every go-code i put "" as an empty string.
How should i document it, to clearify this behavour?
There was a problem hiding this comment.
I'm actually commenting from an user's perspective. From a maintainer's perspective maybe @yxxhero can provide some information...
|
@wrenix oh. I will help me. |
|
Thanks for running the CI-Pipeline - i will take a look. |
replied. |
wrenix
force-pushed
the
patch-1
branch
3 times, most recently
from
3da370a to
9f04d0a
Compare
wrenix
force-pushed
the
patch-1
branch
13 times, most recently
from
b9b2f19 to
11e9dc1
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: WrenIX <[email protected]>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
hmm, maybe it works already - i try it just in an setup like #1213 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
... i need just test |
3 participants
see #447