Cancel rendering helmfile parts once the missing env is detected in the previous part#941
Merged
Conversation
…he previous part Fixes #913 Signed-off-by: Yusuke Kuoka <[email protected]>
mumoshu
changed the title
Member
|
@mumoshu hi. please fix DCO issue. |
…ed in the previous part Signed-off-by: Yusuke Kuoka <[email protected]>
mumoshu
force-pushed
the
fix-subhelmfile-env-skipping
branch
from
92b6141 to
e42bf66
Compare
Member
|
awesome job. @mumoshu |
yxxhero
approved these changes
Jul 23, 2023
Contributor
Author
|
@yxxhero Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #885, Helmfile v0.155.0, we made the missing env detection happen "after all the helmfile parts in a helmfile.yaml(.gotmpl) are rendered and merged".
That was indeed incorrect and resulted in any helmfile template part after the part that defines the
environmentspart potentially failing.This fixes that, by moving the env check a bit earlier than before. It now defers the env check until it sees one or more
environmentsin the accumulated helmfile config.Fixes #913