Stop failing on single helmfile part missing specified env#885
Merged
Conversation
mumoshu
force-pushed
the
fix-missing-env-error-on-helmfile-part
branch
from
c25e59a to
3182a99
Compare
Contributor
Author
|
Please hold on! This resulted in a run like |
mumoshu
force-pushed
the
fix-missing-env-error-on-helmfile-part
branch
from
3182a99 to
7740446
Compare
yxxhero
force-pushed
the
fix-missing-env-error-on-helmfile-part
branch
from
7740446 to
918acae
Compare
mumoshu
force-pushed
the
fix-missing-env-error-on-helmfile-part
branch
from
918acae to
6f4e0f9
Compare
Ref #807 Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
mumoshu
force-pushed
the
fix-missing-env-error-on-helmfile-part
branch
from
44d09b9 to
f9f4972
Compare
Member
|
is ready for reviewing? @mumoshu |
Contributor
Author
|
@yxxhero Yeah! I'd love your review |
Member
|
@mumoshu ok. please review my PR: databus23/helm-diff#469 |
yxxhero
reviewed
Jun 9, 2023
yxxhero
approved these changes
Jun 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes helmfile to not fail in cases like #807 (comment).
I consider this a bug in our validation logic that it was too strict!
The first commit f9f4972 is there for making it easy to update the test snapshots.
Ref #807