Skip to content

feat: inherit field for release template inheritance#606

Merged
mumoshu merged 5 commits into
mainfrom
release-template-inheritance
Dec 28, 2022
Merged

feat: inherit field for release template inheritance#606
mumoshu merged 5 commits into
mainfrom
release-template-inheritance

Conversation

@mumoshu

@mumoshu mumoshu commented Dec 27, 2022

Copy link
Copy Markdown
Contributor

Ref #435 (comment)

Signed-off-by: Yusuke Kuoka [email protected]

@mumoshu mumoshu force-pushed the release-template-inheritance branch 5 times, most recently from 18fc742 to a456ff4 Compare December 27, 2022 03:44
@yxxhero

yxxhero commented Dec 27, 2022

Copy link
Copy Markdown
Member

@mumoshu docs need to be updated.

Comment thread pkg/state/state_exec_tmpl.go
@mumoshu mumoshu force-pushed the release-template-inheritance branch from 54d09a5 to 5dcf252 Compare December 28, 2022 00:10
@mumoshu

mumoshu commented Dec 28, 2022

Copy link
Copy Markdown
Contributor Author

@yxxhero I've updated the documentation via 5dcf252!

Signed-off-by: Yusuke Kuoka <[email protected]>
@yxxhero

yxxhero commented Dec 28, 2022

Copy link
Copy Markdown
Member

@mumoshu first implementation. LGTM.

@mumoshu

mumoshu commented Dec 28, 2022

Copy link
Copy Markdown
Contributor Author

@yxxhero Thanks for reviewing!

@mumoshu mumoshu merged commit 490bb5d into main Dec 28, 2022
@mumoshu mumoshu deleted the release-template-inheritance branch December 28, 2022 01:01
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants