Prepare for bringing back go-yaml v2 to Helmfile v0.x#596
Closed
mumoshu wants to merge 2 commits into
Closed
Conversation
mumoshu
changed the title
mumoshu
force-pushed
the
prepare-yaml-v2-mode
branch
2 times, most recently
from
70576f0 to
950e442
Compare
Ref #435 Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
mumoshu
force-pushed
the
prepare-yaml-v2-mode
branch
from
950e442 to
e07342b
Compare
Member
we should handle the |
Contributor
Author
|
@yxxhero I realized this approach is going to be a dead-end... go-yaml v3 changed their Unmarhsaller interface and we can't implement the UnmarshalYAML function that supports v2 and b3 at the same time. (Related: #587) If the motivation behind migrating to go-yaml v3 was to keep building on something that is well maintained, can we instead migrate to https://github.com/goccy/go-yaml? It's Unmarshaller interface is compatible with go-yaml v2 and is well maintained. |
Member
|
@mumoshu it's valuable to try. |
Member
|
@mumoshu In my opinion. yaml v2 and yaml v3 is different project. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparation or an initial step towards bringing back go-yaml v2 for Helmfile v0.x to retain pre-v0.147.0 behavior while keeping the go-yaml v3 behavior for the upcoming Helmfile v1.x.
Merging this pull request doesn't immediately make Helmfile use go-yaml v2. Merging this doesn't break anything.
Ref #435