Fix preapply hook behavior#423
Merged
Merged
Conversation
Contributor
Author
|
CI seems to have caught the behavior change. I'll update the relevant test data to reflect the change. |
mumoshu
force-pushed
the
fix-preapply-hook
branch
from
469f6f5 to
a3f5ff7
Compare
Contributor
Author
|
@yxxhero This is ready for review. Each additional commit updates the expected log output while moving it from the test case to the corresponding snapshot file so that updating it becomes easier. |
Fixes #399 Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
…havior Signed-off-by: Yusuke Kuoka <[email protected]>
…hook behavior Signed-off-by: Yusuke Kuoka <[email protected]>
…eapply hook behavior Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
yxxhero
force-pushed
the
fix-preapply-hook
branch
from
a3f5ff7 to
b7da096
Compare
Contributor
Author
|
@yxxhero Thanks! For posterity's sake, we should use the "squash and merge" option instead of the standard merge for next circumstance, to avoid polluting the commit history with a lot of fixup commits 🤦♂️ (Sorry about that. I should have squashed to before merging but if you move faster than I it would also be great if you could squash it via UI with the said option! |
Member
|
@mumoshu Ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #399
Signed-off-by: Yusuke Kuoka [email protected]