feat: support HELMFILE_* env vars for more global flags by dschmidt · Pull Request #2606 · helmfile/helmfile

dschmidt · 2026-05-21T17:03:19Z

Summary

Completes the env-var fallback coverage for the remaining global flags, following the pattern of #2593 (HELMFILE_KUBE_CONTEXT) and #2592 (HELMFILE_NAMESPACE):

Flag	Env var
`--helm-binary`	`HELMFILE_HELM_BINARY`
`--kustomize-binary`	`HELMFILE_KUSTOMIZE_BINARY`
`--log-level`	`HELMFILE_LOG_LEVEL`
`--debug`	`HELMFILE_DEBUG`
`--quiet`	`HELMFILE_QUIET`
`--no-color`	`HELMFILE_NO_COLOR` (+ `NO_COLOR`, see below)

Flag values still take precedence; env vars are consulted only when the flag is unset.

NO_COLOR

--no-color is the one special case: in addition to the helmfile-namespaced HELMFILE_NO_COLOR (helmfile-style, expecting "true" lower case), NO_COLOR is also honored per the de-facto no-color.org standard — any non-empty value disables color. HELMFILE_NO_COLOR exists for consistency/granularity with the other helmfile env vars; NO_COLOR for compatibility with the broader ecosystem.

Copilot

Pull request overview

This PR completes environment-variable fallback support for remaining global CLI flags (helm/kustomize binary paths, log-level, debug/quiet, and no-color), aligning with prior HELMFILE_KUBE_CONTEXT / HELMFILE_NAMESPACE behavior. It updates config resolution logic to prefer explicit flags, then fall back to HELMFILE_* env vars, and documents/tests the new behavior (including NO_COLOR support).

Changes:

Add HELMFILE_* env var constants for additional global flags.
Update GlobalImpl to resolve Helm/Kustomize binary, log level, debug/quiet, and no-color via env-var fallbacks.
Update CLI/docs help text and add unit tests for the new env fallback behavior.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`pkg/envvar/const.go`	Adds constants for new `HELMFILE_*` env vars.
`pkg/config/global.go`	Implements env-var fallback logic for additional global config getters.
`pkg/config/global_test.go`	Adds tests covering new flag/env precedence behavior.
`docs/templating.md`	Documents additional supported `HELMFILE_*` env vars and `NO_COLOR`.
`docs/cli.md`	Updates CLI flag descriptions to mention env-var override behavior.
`cmd/root.go`	Adjusts flag defaults/help text and uses env-aware global config in pre-run logging setup.

dschmidt · 2026-05-22T00:18:44Z

 func (g *GlobalImpl) HelmBinary() string {
-	return g.GlobalOptions.HelmBinary
+	var helmBinary string
+
+	switch {
+	case g.GlobalOptions.HelmBinary != "":
+		helmBinary = g.GlobalOptions.HelmBinary
+	case os.Getenv("HELMFILE_HELM_BINARY") != "":
+		helmBinary = os.Getenv("HELMFILE_HELM_BINARY")
+	default:
+		helmBinary = state.DefaultHelmBinary
+	}
+	return helmBinary
 }

 // KustomizeBinary returns the path to the Kustomize binary.
 func (g *GlobalImpl) KustomizeBinary() string {
-	return g.GlobalOptions.KustomizeBinary
+	var kustomizeBinary string
+
+	switch {
+	case g.GlobalOptions.KustomizeBinary != "":
+		kustomizeBinary = g.GlobalOptions.KustomizeBinary
+	case os.Getenv("HELMFILE_KUSTOMIZE_BINARY") != "":
+		kustomizeBinary = os.Getenv("HELMFILE_KUSTOMIZE_BINARY")
+	default:
+		kustomizeBinary = state.DefaultKustomizeBinary
+	}
+	return kustomizeBinary
+}
+
+// LogLevel returns the log level to use.
+func (g *GlobalImpl) LogLevel() string {
+	var logLevel string
+
+	switch {
+	case g.GlobalOptions.LogLevel != "":
+		logLevel = g.GlobalOptions.LogLevel
+	case os.Getenv("HELMFILE_LOG_LEVEL") != "":
+		logLevel = os.Getenv("HELMFILE_LOG_LEVEL")
+	default:
+		logLevel = "info"
+	}


Keeping the literal env-var strings here for git grep HELMFILE_HELM_BINARY (and friends) symmetry with the existing Env() / KubeContext() / Namespace() precedent — same rationale that was accepted on #2593.

dschmidt · 2026-05-22T00:18:52Z

 // NoColor returns the no color flag
 func (g *GlobalImpl) NoColor() bool {
-	return g.GlobalOptions.NoColor
+	if g.GlobalOptions.NoColor {
+		return true
+	}
+	if os.Getenv(envvar.NoColor) == "true" {
+		return true
+	}
+	// Honor the de-facto https://no-color.org/ standard: any non-empty value disables color.
+	return os.Getenv("NO_COLOR") != ""
 }


Addressed in commit 6720ed2. Color() now routes through the env-aware NoColor() before falling back to TTY autodetect, so HELMFILE_NO_COLOR / NO_COLOR in a terminal no longer triggers a spurious --color and --no-color validation error. Regression test added (TestColorRespectsNoColorEnv).

dschmidt · 2026-05-22T00:19:00Z

+// TestHelmBinary tests the helm-binary flag and HELMFILE_HELM_BINARY env var fallback
+func TestHelmBinary(t *testing.T) {
+	tests := []struct {
+		opts     GlobalOptions
+		env      string
+		expected string
+	}{
+		{
+			opts:     GlobalOptions{},
+			env:      "",
+			expected: "helm",
+		},
+		{
+			opts:     GlobalOptions{},
+			env:      "envset",
+			expected: "envset",
+		},
+		{
+			opts:     GlobalOptions{HelmBinary: "flagset"},
+			env:      "",
+			expected: "flagset",
+		},
+		{
+			opts:     GlobalOptions{HelmBinary: "flagset"},
+			env:      "envset",
+			expected: "flagset",
+		},
+	}
+
+	for _, test := range tests {
+		os.Setenv(envvar.HelmBinary, test.env)
+		received := NewGlobalImpl(&test.opts).HelmBinary()
+		require.Equalf(t, test.expected, received, "HelmBinary expected %s, received %s", test.expected, received)
+	}
+	os.Unsetenv(envvar.HelmBinary)


Keeping the existing os.Setenv test style for consistency with TestFileOrDir / TestKubeContext / TestNamespace in the same file — same rationale that was accepted on #2593.

dschmidt · 2026-05-21T22:27:41Z

Re. the Copilot review:

Finding 2 (NoColor/Color/ValidateConfig interaction) — addressed in the new fix commit (fix: Color() must honor env-driven NoColor() before TTY autodetect). With HELMFILE_NO_COLOR=true or NO_COLOR=1 set in a TTY, Color() used to fall through to terminal autodetect and ValidateConfig() would error spuriously. Added regression test.
Finding 1 (use envvar.* constants + single os.Getenv for the string getters) — same comment as on feat: support HELMFILE_KUBE_CONTEXT env var for default kube context #2593; keeping the literal env-var strings for git grep symmetry with the existing Env() / KubeContext() / Namespace() precedent, as accepted there.
Finding 3 (t.Setenv instead of os.Setenv in the tests) — same comment as on feat: support HELMFILE_KUBE_CONTEXT env var for default kube context #2593; keeping the existing test style for consistency with the surrounding cases, as accepted there.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

dschmidt · 2026-05-22T00:19:07Z

+
+	switch {
+	case g.GlobalOptions.HelmBinary != "":
+		helmBinary = g.GlobalOptions.HelmBinary
+	case os.Getenv("HELMFILE_HELM_BINARY") != "":
+		helmBinary = os.Getenv("HELMFILE_HELM_BINARY")


Same rationale as the round-1 comment above: keeping the literal env-var string for git grep HELMFILE_HELM_BINARY symmetry with the Env() / KubeContext() / Namespace() precedent accepted on #2593.

dschmidt · 2026-05-22T00:19:15Z

+
+	switch {
+	case g.GlobalOptions.KustomizeBinary != "":
+		kustomizeBinary = g.GlobalOptions.KustomizeBinary
+	case os.Getenv("HELMFILE_KUSTOMIZE_BINARY") != "":
+		kustomizeBinary = os.Getenv("HELMFILE_KUSTOMIZE_BINARY")


Same rationale — keeping the literal "HELMFILE_KUSTOMIZE_BINARY" for git grep symmetry with the Env() / KubeContext() / Namespace() precedent accepted on #2593.

dschmidt · 2026-05-22T00:19:22Z

+
+	switch {
+	case g.GlobalOptions.LogLevel != "":
+		logLevel = g.GlobalOptions.LogLevel
+	case os.Getenv("HELMFILE_LOG_LEVEL") != "":
+		logLevel = os.Getenv("HELMFILE_LOG_LEVEL")


Same rationale — keeping the literal "HELMFILE_LOG_LEVEL" for git grep symmetry with the Env() / KubeContext() / Namespace() precedent accepted on #2593.

dschmidt · 2026-05-22T00:19:30Z

+	if g.GlobalOptions.NoColor {
+		return true
+	}
+	if os.Getenv(envvar.NoColor) == "true" {
+		return true
+	}
+	// Honor the de-facto https://no-color.org/ standard: any non-empty value disables color.
+	return os.Getenv("NO_COLOR") != ""


Good catch — addressed in commit 6720ed2. NoColor() now short-circuits on an explicit --color flag before consulting the env vars, so helmfile --color always wins over NO_COLOR / HELMFILE_NO_COLOR (flag should beat env). The --color --no-color mutual-exclusion error is preserved because both flag fields are still checked. Regression test added (TestColorFlagOverridesNoColorEnv).

dschmidt · 2026-05-22T00:19:39Z

+	for _, test := range tests {
+		os.Setenv(envvar.HelmBinary, test.env)
+		received := NewGlobalImpl(&test.opts).HelmBinary()
+		require.Equalf(t, test.expected, received, "HelmBinary expected %s, received %s", test.expected, received)
+	}
+	os.Unsetenv(envvar.HelmBinary)
+}


Same as the round-1 comment — keeping os.Setenv for consistency with TestFileOrDir / TestKubeContext / TestNamespace in the same file (the precedent accepted on #2593).

yxxhero · 2026-05-22T00:04:04Z

@dschmidt last comments.

Adds env-var fallbacks for global flags, mirroring the existing HELMFILE_ENVIRONMENT / HELMFILE_KUBE_CONTEXT pattern: * --helm-binary -> HELMFILE_HELM_BINARY * --kustomize-binary -> HELMFILE_KUSTOMIZE_BINARY * --log-level -> HELMFILE_LOG_LEVEL * --debug -> HELMFILE_DEBUG (expecting "true" lower case) * --quiet -> HELMFILE_QUIET (expecting "true" lower case) * --no-color -> HELMFILE_NO_COLOR (expecting "true" lower case), additionally honors NO_COLOR per no-color.org (any non-empty value disables color) Flag values still take precedence; env vars are consulted only when the flag is unset. The string-flag default values ("helm", "kustomize", "info") move into the accessor methods so the env-var fallback can actually trigger when no flag is passed. Signed-off-by: Dominik Schmidt <[email protected]>

Signed-off-by: Dominik Schmidt <[email protected]>

Two issues with the env-aware NoColor() introduced together with HELMFILE_NO_COLOR / NO_COLOR support: 1. Color() consulted the raw GlobalOptions.NoColor field instead of NoColor(), so in a TTY with only the env set, Color() fell through to terminal autodetect and ValidateConfig() spuriously errored with "--color and --no-color cannot be specified at the same time". 2. NoColor() returned true via env even when --color was explicitly passed, so `helmfile --color` with NO_COLOR (or HELMFILE_NO_COLOR=true) in the environment hit the same ValidateConfig() error. A flag should always win over an env var. Fix both by routing Color() through NoColor() and giving NoColor() an explicit --color short-circuit. Regression tests added for both paths. Signed-off-by: Dominik Schmidt <[email protected]>

dschmidt · 2026-05-22T00:21:03Z

@yxxhero replied inline to each of the 8 review comments. The two substantive ones (Color/NoColor interaction in both directions) are addressed in 6720ed2 with regression tests; the six style ones follow the same precedent you accepted on #2593 (literal env-var strings for grep symmetry, os.Setenv test style for consistency with surrounding cases). What do you think?

yxxhero · 2026-05-22T00:22:13Z

@yxxhero replied inline to each of the 8 review comments. The two substantive ones (Color/NoColor interaction in both directions) are addressed in 6720ed2 with regression tests; the six style ones follow the same precedent you accepted on #2593 (literal env-var strings for grep symmetry, os.Setenv test style for consistency with surrounding cases). What do you think?

@dschmidt all is ok. waiting the ci passs. BTW. do you want to join helmfile group?

dschmidt · 2026-05-22T00:24:42Z

sure. :)

yxxhero · 2026-05-22T00:26:29Z

sure. :)

got it. I'll push the process.

dschmidt requested review from aditmeno, itscaro, mumoshu, xiaomudk, yxxhero and zhaque44 as code owners May 21, 2026 17:03

dschmidt force-pushed the feat/more-env-vars branch 2 times, most recently from 59d408a to cb39196 Compare May 21, 2026 17:09

yxxhero requested a review from Copilot May 21, 2026 22:02

Copilot started reviewing on behalf of yxxhero May 21, 2026 22:02 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

dschmidt force-pushed the feat/more-env-vars branch from cb39196 to 8ee1e0a Compare May 21, 2026 22:18

yxxhero requested a review from Copilot May 21, 2026 22:26

Copilot started reviewing on behalf of yxxhero May 21, 2026 22:26 View session

dschmidt force-pushed the feat/more-env-vars branch from 8ee1e0a to 180f59d Compare May 21, 2026 22:27

Copilot AI reviewed May 21, 2026

View reviewed changes

dschmidt force-pushed the feat/more-env-vars branch from 180f59d to 6720ed2 Compare May 21, 2026 22:39

dschmidt added 3 commits May 22, 2026 08:20

docs: mention new HELMFILE_* env vars in cli.md and templating.md

898521b

Signed-off-by: Dominik Schmidt <[email protected]>

yxxhero force-pushed the feat/more-env-vars branch from 6720ed2 to ef8ed9e Compare May 22, 2026 00:20

yxxhero approved these changes May 22, 2026

View reviewed changes

yxxhero merged commit 33eadc9 into helmfile:main May 22, 2026
16 checks passed

Uh oh!

Uh oh!

Conversation

dschmidt commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

NO_COLOR

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dschmidt commented May 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yxxhero commented May 22, 2026

Uh oh!

dschmidt commented May 22, 2026

Uh oh!

yxxhero commented May 22, 2026

Uh oh!

dschmidt commented May 22, 2026

Uh oh!

yxxhero commented May 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dschmidt commented May 21, 2026 •

edited

Loading