Add jsonPatches regression coverage for chartify lookup rendering by Copilot · Pull Request #2586 · helmfile/helmfile

Copilot · 2026-05-12T17:12:12Z

jsonPatches could change the rendering path used for patched releases, causing charts that rely on Helm lookup to behave like client-side renders even when diff/apply should preserve cluster-backed values. This shows up as unstable diffs where looked-up values are regenerated on every run.

What changed
- Extended the existing issue-2271 integration scenario to exercise both patch modes that go through chartify:
  - strategicMergePatches
  - jsonPatches
- Reused the same install → mutate live object → diff flow so both paths are checked against the same lookup preservation behavior.
Regression fixture
- Added a dedicated helmfile-jsonpatch.yaml input that applies a JSON patch to the test Deployment without depending on ambiguous/nonexistent paths.
- The patch targets an existing label path in the pod template, keeping the fixture focused on render-path behavior rather than patch-shape edge cases.
Why this matters
- This locks in the expectation that enabling jsonPatches must not change lookup semantics for cluster-aware commands.
- Future changes in chartify / kustomize integration will now be checked against both patch variants, not just strategic merge patches.

releases:
  - name: test-release-2271
    namespace: default
    chart: ./test-chart
    jsonPatches:
      - target:
          group: apps
          version: v1
          kind: Deployment
          name: test-release-2271-app
          namespace: default
        patch:
          - op: add
            path: /spec/template/metadata/labels/hello
            value: world

Copilot

Pull request overview

Expands the existing issue-2271 integration regression test to ensure Helm lookup behavior remains cluster-backed when kustomize/chartify patching is enabled, covering both strategicMergePatches and jsonPatches.

Changes:

Added a dedicated helmfile-jsonpatch.yaml input that applies a JSON6902 patch to the test Deployment.
Refactored the issue-2271 integration test script to run the same “install → mutate live object → diff” assertion for both patch modes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
test/integration/test-cases/issue-2271/input/helmfile-jsonpatch.yaml	Adds a JSON patch fixture targeting an existing Deployment label path to exercise the jsonPatches render path.
test/integration/test-cases/issue-2271.sh	Updates the regression test flow to assert lookup preservation for both strategicMergePatches and jsonPatches.

+  ${helmfile} -f "${helmfile_path}" diff > "${output_path}" 2>&1
+  code=$?
+
+  # Check if the diff contains the preserved value (not "initial-value")
+  if grep -q "preserved-value.*test-preserved-value" "${output_path}"; then


yxxhero · 2026-05-15T23:20:26Z

@copilot fix comments

Copilot · 2026-05-15T23:25:51Z

@copilot fix comments

Fixed in c68258c. The issue-2271 helper now keeps code local and fails unless helmfile diff returns 0 or 2, so plugin/runtime errors can no longer be reported as success.

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/72b7ba14-50b8-4407-ba37-6da202609603 Co-authored-by: zhaque44 <[email protected]>

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/5615c543-f96b-44ed-be25-ca1559ee6ab0 Co-authored-by: yxxhero <[email protected]>

Copilot AI assigned Copilot and zhaque44 May 12, 2026

Copilot started work on behalf of zhaque44 May 12, 2026 17:12 View session

Copilot AI linked an issue May 12, 2026 that may be closed by this pull request

Using jsonPatches changes which subprogram renders the chart #1977

Closed

Copilot AI changed the title ~~[WIP] Fix jsonPatches changes on chart rendering~~ Add jsonPatches regression coverage for chartify lookup rendering May 12, 2026

Copilot finished work on behalf of zhaque44 May 12, 2026 17:32

Copilot AI requested a review from zhaque44 May 12, 2026 17:32

yxxhero marked this pull request as ready for review May 15, 2026 22:31

yxxhero requested review from aditmeno, itscaro, mumoshu, xiaomudk and yxxhero as code owners May 15, 2026 22:31

yxxhero force-pushed the copilot/fix-jsonpatches-chart-rendering branch from f62aae6 to aff47db Compare May 15, 2026 22:31

yxxhero requested a review from Copilot May 15, 2026 22:32

Copilot started reviewing on behalf of yxxhero May 15, 2026 22:32 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

Copilot started work on behalf of yxxhero May 15, 2026 23:20 View session

Copilot finished work on behalf of yxxhero May 15, 2026 23:26

yxxhero removed a link to an issue May 20, 2026

Using jsonPatches changes which subprogram renders the chart #1977

Closed

Copilot AI and others added 4 commits May 20, 2026 14:12

test: cover jsonPatches lookup regression

8ba4070

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/72b7ba14-50b8-4407-ba37-6da202609603 Co-authored-by: zhaque44 <[email protected]>

test: simplify json patch fixture

b8aa223

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/72b7ba14-50b8-4407-ba37-6da202609603 Co-authored-by: zhaque44 <[email protected]>

test: target existing json patch path

1c081a3

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/72b7ba14-50b8-4407-ba37-6da202609603 Co-authored-by: zhaque44 <[email protected]>

test: validate diff exit codes in issue-2271

d23df4a

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/5615c543-f96b-44ed-be25-ca1559ee6ab0 Co-authored-by: yxxhero <[email protected]>

yxxhero force-pushed the copilot/fix-jsonpatches-chart-rendering branch from c68258c to d23df4a Compare May 20, 2026 06:12

yxxhero approved these changes May 20, 2026

View reviewed changes

yxxhero merged commit 2f2e861 into main May 20, 2026
16 checks passed

yxxhero deleted the copilot/fix-jsonpatches-chart-rendering branch May 20, 2026 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add jsonPatches regression coverage for chartify lookup rendering#2586

Add jsonPatches regression coverage for chartify lookup rendering#2586
yxxhero merged 4 commits into
mainfrom
copilot/fix-jsonpatches-chart-rendering

Copilot AI commented May 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

yxxhero commented May 15, 2026

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Copilot AI commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

yxxhero commented May 15, 2026

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented May 12, 2026 •

edited

Loading