fix: template helmDefaults.postRendererArgs with release data by yxxhero · Pull Request #2583 · helmfile/helmfile

yxxhero · 2026-05-08T00:03:07Z

Summary

Fix helmDefaults.postRendererArgs containing template expressions (e.g. {{ .Release.Name }}) being passed to helm as literal strings instead of being resolved per-release
Add renderPostRendererArgs() that templates helmDefaults args at flag-generation time, reusing the existing createReleaseTemplateData() helper
Add unit tests for the templating behavior and an integration test case

Context

PR #1839 introduced template rendering for postRendererArgs, but PR #2510 reverted it while fixing a separate regression (broken bases import and CLI argument override). This left helmDefaults-level postRendererArgs untemplated.

Changes

pkg/state/helmx.go: When appendPostRenderArgsFlags falls through to st.HelmDefaults.PostRendererArgs, render template expressions using st.createReleaseTemplateData() before passing to helm
pkg/state/state_test.go: Add 2 test cases verifying {{ .Release.Name }} and {{ .Release.Namespace }} resolution
test/integration/test-cases/postrender-defaults-args/: Integration test with a post-renderer that echoes the templated arg as a ConfigMap name, verifying per-release resolution

Fixes #2580

Copilot

Pull request overview

This PR restores/extends Helmfile’s template rendering for helmDefaults.postRendererArgs so expressions like {{ .Release.Name }} are resolved per-release (instead of being passed to Helm literally), addressing a regression introduced by earlier fixes around post-renderer flag precedence.

Changes:

Template-render helmDefaults.postRendererArgs at flag generation time using release template data.
Add unit tests validating templating of {{ .Release.Name }} / {{ .Release.Namespace }} in helm-default args.
Add an integration test case that verifies per-release rendered args via a post-renderer.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/state/helmx.go	Renders `helmDefaults.postRendererArgs` with release template data before generating Helm flags.
pkg/state/state_test.go	Adds unit tests covering templating of helm-default post-renderer args.
test/integration/run.sh	Wires the new integration test case into the integration test runner.
test/integration/test-cases/postrender-defaults-args.sh	Executes `helmfile template` and asserts rendered arg output is per-release.
test/integration/test-cases/postrender-defaults-args/input/helmfile.yaml.gotmpl	Defines a test helmfile with templated `helmDefaults.postRendererArgs`.
test/integration/test-cases/postrender-defaults-args/input/echo-args.bash	Helm 3 post-renderer script that emits a ConfigMap referencing the passed arg.
test/integration/test-cases/postrender-defaults-args/input/helm-plugin-echo-args/plugin.yaml	Helm 4 post-renderer plugin definition for the integration test.
test/integration/test-cases/postrender-defaults-args/input/helm-plugin-echo-args/echo-args.sh	Helm 4 plugin script variant for emitting a ConfigMap referencing the passed arg.

@@ -0,0 +1,30 @@
+helmDefaults:
+  postRenderer: {{ if eq (env "HELMFILE_HELM4") "1" }}add-cm{{ else }}./echo-args.bash{{ end }}


+		rendered, err := renderer.RenderTemplateContentToString([]byte(arg))
+		if err != nil {
+			if st.logger != nil {
+				st.logger.Warnf("failed rendering postRendererArg %q for release %q: %v", arg, release.Name, err)
+			}


yxxhero · 2026-05-08T01:34:27Z

@allanger could you try to use this branch.

PR #1839 introduced template rendering for postRendererArgs, but PR #2510 reverted it while fixing a separate regression. This left helmDefaults-level postRendererArgs containing template expressions (e.g. {{ .Release.Name }}) passed to helm as literal strings instead of being resolved per-release. Add renderPostRendererArgs() that templates helmDefaults.postRendererArgs at flag-generation time using the release's template data, reusing the existing createReleaseTemplateData() helper. Release-level args are already templated by ExecuteTemplateExpressions and CLI args are static, so only the helmDefaults path needs rendering. Fixes #2580 Signed-off-by: opencode <[email protected]> Signed-off-by: yxxhero <[email protected]>

allanger · 2026-05-08T08:07:45Z

@yxxhero I will try on the weekend, thanks

allanger · 2026-05-10T08:39:59Z

@yxxhero I've tested my use cases, and the version from this branch seems to work fine. Thanks!

yxxhero requested review from aditmeno, itscaro, mumoshu, xiaomudk and zhaque44 as code owners May 8, 2026 00:03

yxxhero requested a review from Copilot May 8, 2026 00:11

Copilot started reviewing on behalf of yxxhero May 8, 2026 00:11 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

yxxhero force-pushed the fix/postrenderer-args-template-helmdefaults branch from 7c58228 to fc8405e Compare May 8, 2026 00:25

yxxhero force-pushed the fix/postrenderer-args-template-helmdefaults branch from fc8405e to 4661552 Compare May 8, 2026 01:34

xiaomudk approved these changes May 11, 2026

View reviewed changes

yxxhero merged commit c82c61e into main May 11, 2026
16 checks passed

yxxhero deleted the fix/postrenderer-args-template-helmdefaults branch May 11, 2026 01:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: template helmDefaults.postRendererArgs with release data#2583

fix: template helmDefaults.postRendererArgs with release data#2583
yxxhero merged 1 commit into
mainfrom
fix/postrenderer-args-template-helmdefaults

yxxhero commented May 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

yxxhero commented May 8, 2026

Uh oh!

allanger commented May 8, 2026

Uh oh!

allanger commented May 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1,30 @@
		helmDefaults:
		postRenderer: {{ if eq (env "HELMFILE_HELM4") "1" }}add-cm{{ else }}./echo-args.bash{{ end }}

Uh oh!

Uh oh!

Conversation

yxxhero commented May 8, 2026

Summary

Context

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

yxxhero commented May 8, 2026

Uh oh!

allanger commented May 8, 2026

Uh oh!

allanger commented May 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants