fix(state): resolve OCI repo prefix in ad-hoc release dependencies by dschmidt · Pull Request #2579 · helmfile/helmfile

dschmidt · 2026-05-07T06:34:32Z

Summary

When a release's dependencies[].chart is given as <repoName>/<chart> and the matching repositories: entry has oci: true, helmfile now rewrites it to oci://<repoURL>/<chart> before handing it to chartify. Without this rewrite, chartify falls into its helm repo list lookup branch, which never finds OCI repos because since helm 3 OCI registries are no longer registered as named repos (they live in the helm registry login state instead). The user-visible failure was:

failed reading adhoc dependencies: no helm list entry found for repository "<name>". please `helm repo add` it!

Explicit oci:// URLs already worked through chartify's OCI branch on main; this change makes the <repoName>/<chart> form behave the same way.

Fixes #1756.

Why this fix lives in helmfile, not chartify

Chartify's OCI branch is already correct: it produces a valid Chart.yaml dependency entry with repository: oci://... that helm dependency build resolves. The bug is purely upstream of chartify: helmfile passes the <repoName>/<chart> string through verbatim, never consulting its own repositories: list. Resolving the prefix in helmfile keeps chartify untouched and reuses the code path that's already proven to work for explicit oci:// URLs.

Reproduction (verified)

A local OCI registry plus a minimal helmfile reproduces the bug on main and is fixed by this PR:

docker run -d --rm -p 5555:5000 --name reg registry:2
helm create redis-mock && helm package redis-mock
helm push redis-mock-0.1.0.tgz oci://localhost:5555/test

# helmfile.yaml
repositories:
  - name: localreg
    url: localhost:5555/test
    oci: true

releases:
  - name: parent
    chart: ./parent-app
    dependencies:
      - chart: localreg/redis-mock     # the bug case
        version: 0.1.0

Before: failed reading adhoc dependencies: no helm list entry found for repository "localreg".

After: chart renders, with a debug log confirming the rewrite:

ad-hoc dependency "localreg/redis-mock" rewritten to "oci://localhost:5555/test/redis-mock" (matched OCI repo entry)

Scope

The rewrite is deliberately conservative. The six cases covered in TestResolveOCIAdhocDepChart:

Input	Result
`ociregistry/redis` (matches OCI repo)	rewritten to `oci://...`
`ociregistry-trailing/redis` (URL ends with `/`)	rewritten without double slash
`stable/nginx` (matches non-OCI repo)	unchanged: chartify's existing repo-list path handles it
`oci://...` (explicit URL)	unchanged: already in chartify's OCI branch
`unknownrepo/something`	unchanged: chartify reports the repo-not-found error as before
`localchart` (no slash)	unchanged

Local-directory dependencies (st.fs.DirectoryExistsAt(chart)) keep their existing absolute-path resolution and are not affected by the rewrite.

Note on comment by @artemis-mike in #1756

They used a full oci:// URL form (comment) and report a different downstream error (found in Chart.yaml, but missing in charts/ directory). I could not reproduce that one without their exact setup (private registry, remote parent chart, basic auth). Explicit oci:// URL deps work in my reproduction on main already. That case is likely either auth-state or remote-parent specific and out of scope for this PR; I'd suggest opening a focused issue for it once we have a clean repro.

When a release `dependencies[].chart` is given as `<repoName>/<chart>` and the matching `repositories:` entry has `oci: true`, helmfile now rewrites it to `oci://<repoURL>/<chart>` before passing it to chartify. Without this, chartify's lookup falls into its `helm repo list` branch, which never finds OCI repos because helm 3+ does not register OCI registries as named repos (they live in the `helm registry login` state instead). The user-visible failure was: failed reading adhoc dependencies: no helm list entry found for repository "<name>". please `helm repo add` it! Explicit `oci://` URLs already worked through chartify's OCI branch; this change makes the `<repoName>/<chart>` form behave the same way. Non-OCI repo prefixes, unknown prefixes, single-segment names, and explicit `oci://` URLs all pass through unchanged. A debug log records each rewrite at the call site for easier troubleshooting. Fixes helmfile#1756. Signed-off-by: Dominik Schmidt <[email protected]>

Copilot

Pull request overview

This PR fixes Helmfile’s handling of ad-hoc release dependencies that reference charts via the repoName/chart form when the referenced repositories: entry is an OCI repo (oci: true). It rewrites those dependency chart references to oci://<repoURL>/<chart> so chartify takes its OCI codepath instead of attempting a helm repo list lookup that can’t succeed for OCI registries.

Changes:

Add HelmState.resolveOCIAdhocDepChart to rewrite repoName/chart into an oci://... URL when the repo is configured as OCI.
Apply the rewrite during PrepareChartify when building AdhocChartDependencies for chartify.
Add a unit test covering expected rewrite and no-op cases.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
pkg/state/state.go	Adds helper to rewrite ad-hoc dependency chart references for OCI repos.
pkg/state/helmx.go	Uses the helper during chartify preparation and logs the rewrite at debug level.
pkg/state/state_test.go	Adds unit tests validating rewrite behavior across several cases.

dschmidt requested review from aditmeno, itscaro, mumoshu, xiaomudk, yxxhero and zhaque44 as code owners May 7, 2026 06:34

dschmidt force-pushed the fix/oci-adhoc-dependency branch from 708f172 to b7e8b66 Compare May 7, 2026 06:41

yxxhero requested a review from Copilot May 7, 2026 08:13

Copilot started reviewing on behalf of yxxhero May 7, 2026 08:14 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread pkg/state/state.go

yxxhero approved these changes May 7, 2026

View reviewed changes

yxxhero merged commit c6d0310 into helmfile:main May 7, 2026
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(state): resolve OCI repo prefix in ad-hoc release dependencies#2579

fix(state): resolve OCI repo prefix in ad-hoc release dependencies#2579
yxxhero merged 1 commit into
helmfile:mainfrom
dschmidt:fix/oci-adhoc-dependency

dschmidt commented May 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

dschmidt commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why this fix lives in helmfile, not chartify

Reproduction (verified)

Scope

Note on comment by @artemis-mike in #1756

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dschmidt commented May 7, 2026 •

edited

Loading