fix: add trackFailOnError option to control kubedog exit code by yxxhero · Pull Request #2576 · helmfile/helmfile

yxxhero · 2026-05-03T22:09:26Z

Summary

Fixes helmfile with kubedog release tracking has exit code 0 even when release failed #2507: helmfile exits with code 0 when kubedog release tracking fails (e.g. pod ImagePullBackOff)
Adds trackFailOnError option (default: false) to let users opt in to non-zero exit codes on kubedog tracking failures
Extracts trackReleaseIfEnabled helper to consolidate duplicated kubedog tracking logic into a single method

Usage

Per-release YAML:

releases:
  - name: myapp
    trackMode: kubedog
    trackFailOnError: true   # non-zero exit on kubedog failure

CLI:

helmfile apply --track-mode kubedog --track-fail-on-error

Files changed

File	Change
`pkg/state/state.go`	`TrackFailOnError` field on `ReleaseSpec` and `SyncOpts`; call sites use new helper
`pkg/state/helmx.go`	`shouldFailOnTrackError` resolver + `trackReleaseIfEnabled` consolidated helper
`pkg/config/sync.go`	`TrackFailOnError` field + accessor on `SyncOptions`/`SyncImpl`
`pkg/config/apply.go`	`TrackFailOnError` field + accessor on `ApplyOptions`/`ApplyImpl`
`pkg/app/config.go`	`TrackFailOnError() bool` added to `ApplyConfigProvider` and `SyncConfigProvider` interfaces
`cmd/sync.go`	`--track-fail-on-error` CLI flag
`cmd/apply.go`	`--track-fail-on-error` CLI flag
`pkg/app/app.go`	Wire `TrackFailOnError` from config to `SyncOpts`
`pkg/app/app_test.go`	Add field + method to test `applyConfig` mock

When kubedog release tracking fails (e.g. pod ImagePullBackOff), helmfile exits with code 0 instead of a non-zero exit code. Add a trackFailOnError configuration option (default: false) that when set to true, propagates kubedog tracking failures to the exit code. The option is available as: - Per-release YAML: trackFailOnError: true - CLI flag: --track-fail-on-error (sync and apply commands) Extract trackReleaseIfEnabled helper to consolidate kubedog tracking logic from two duplicated call sites into a single maintainable method. Fixes #2507 Signed-off-by: yxxhero <[email protected]>

yxxhero · 2026-05-03T22:26:33Z

@copilot fix ci issue.

The test/integration/test-cases/issue-2103/input/server.go is a package main helper binary used by the issue-2103 integration test. When go test -coverprofile runs on this package, it fails with "go: no such tool covdata" in the CI environment. Adding //go:build ignore excludes the file from go list ./... (and therefore from PKGS in the Makefile), while still allowing the integration test to build it explicitly via file path: go build -o server ./path/to/server.go Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/8a7000af-72b7-48f8-8a82-24813b5df341 Co-authored-by: yxxhero <[email protected]>

Copilot · 2026-05-03T22:38:04Z

@copilot fix ci issue.

Fixed in 923e9b1. The CI failure was caused by test/integration/test-cases/issue-2103/input/server.go (a package main helper binary) being picked up by go test -coverprofile ./..., which failed with go: no such tool "covdata". Added //go:build ignore to the file, which excludes it from go list ./... and therefore from make test, while the integration test can still build it explicitly via its file path (go build -o server ./path/to/server.go).

yxxhero · 2026-05-03T22:51:47Z

@copilot === RUN TestGenerateID/baseline
temp_test.go:38: unexpected result: want (-), got (+):
string(
- "foo-values-6ccb848dcd",
+ "foo-values-7f6f8d74dd",
)
=== RUN TestGenerateID/different_bytes_content
temp_test.go:44: unexpected result: want (-), got (+):
string(
- "foo-values-5bcbbc4c85",
+ "foo-values-5fc74c864c",
)
=== RUN TestGenerateID/different_map_content
temp_test.go:51: unexpected result: want (-), got (+):
string(
- "foo-values-7c6468f955",
+ "foo-values-77df88dd65",
)
=== RUN TestGenerateID/different_chart
temp_test.go:58: unexpected result: want (-), got (+):
string(
- "foo-values-8645f5847f",
+ "foo-values-77c96457f7",
)
=== RUN TestGenerateID/different_name
temp_test.go:64: unexpected result: want (-), got (+):
string(
- "bar-values-54bd8c865",
+ "bar-values-6695f7ff4c",
)
=== RUN TestGenerateID/specific_ns
temp_test.go:70: unexpected result: want (-), got (+):
string(
- "myns-foo-values-b4849b445",
+ "myns-foo-values-9b9484d4c",

…ror field Adding TrackFailOnError *bool to ReleaseSpec changed the spew serialization of the struct, which changed the FNV-32a hash values produced by generateValuesID. Update temp_test.go with the new expected hash strings. Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/caa86cd9-73d1-4894-b745-fd70c0811fd6 Co-authored-by: yxxhero <[email protected]>

Copilot · 2026-05-03T22:57:20Z

@copilot === RUN TestGenerateID/baseline
temp_test.go:38: unexpected result: want (-), got (+):
string(
...

Fixed in 36727df. Adding TrackFailOnError *bool to ReleaseSpec changed the struct's spew serialization, which shifted the FNV-32a hash values produced by generateValuesID. Updated the six expected hash strings in temp_test.go to match the new values.

docs: update helmfile skill to reflect v1.1 documentation (#2576) - Add Helmfile v1.0/v1.1 status and Helm 4 support - Expand release configuration fields with tracking, templating, and ownership options - Add new CLI commands: fetch, unittest, show-dag, write-values, build, cache, create - Add values merging and data flow precedence documentation - Expand hooks with preapply, preuninstall, postuninstall events and kubectlApply - Add kubedog resource tracking (helm/helm-legacy/kubedog modes) - Add JSON patches and template partials documentation - Complete remote secrets (vals) with fetchSecretValue and expandSecretRefs - Add comprehensive repository configuration (OCI, TLS, GPG verify) - Update metadata version to 1.1.0 Signed-off-by: yxxhero <[email protected]>

yxxhero requested review from aditmeno, itscaro, mumoshu, xiaomudk and zhaque44 as code owners May 3, 2026 22:09

Copilot started work on behalf of yxxhero May 3, 2026 22:26 View session

Copilot finished work on behalf of yxxhero May 3, 2026 22:38

Copilot started work on behalf of yxxhero May 3, 2026 22:51 View session

Copilot finished work on behalf of yxxhero May 3, 2026 22:57

xiaomudk approved these changes May 4, 2026

View reviewed changes

yxxhero merged commit 420cc3b into main May 4, 2026
16 checks passed

yxxhero deleted the fix/kubedog-exit-code-2507 branch May 4, 2026 06:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: add trackFailOnError option to control kubedog exit code#2576

fix: add trackFailOnError option to control kubedog exit code#2576
yxxhero merged 3 commits into
mainfrom
fix/kubedog-exit-code-2507

yxxhero commented May 3, 2026

Uh oh!

yxxhero commented May 3, 2026

Uh oh!

Copilot AI commented May 3, 2026

Uh oh!

yxxhero commented May 3, 2026

Uh oh!

Copilot AI commented May 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

yxxhero commented May 3, 2026

Summary

Usage

Files changed

Uh oh!

yxxhero commented May 3, 2026

Uh oh!

Copilot AI commented May 3, 2026

Uh oh!

yxxhero commented May 3, 2026

Uh oh!

Copilot AI commented May 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants