fix: use --post-renderer-args=VALUE format to prevent Helm flag parsing failure by yxxhero · Pull Request #2570 · helmfile/helmfile

yxxhero · 2026-05-02T01:08:01Z

Summary

Changed --post-renderer-args to use --post-renderer-args=VALUE format instead of passing flag and value as separate arguments
This prevents Helm from misinterpreting post-renderer args that look like flags (e.g. -v) as independent Helm flags

Problem

When postRendererArgs contains values like short flags (e.g. -v), passing --post-renderer-args and the value as separate arguments causes Helm to interpret the value as its own flag:

--post-renderer foo --post-renderer-args -v --namespace ns

Helm sees -v as a standalone flag rather than the value for --post-renderer-args.

Solution

Using the --post-renderer-args=VALUE format unambiguously binds the value to the flag:

--post-renderer foo --post-renderer-args=-v --namespace ns

Fixes #2563

Signed-off-by: opencode [email protected]

…ng failure When postRendererArgs contains values like short flags (e.g. -v), passing --post-renderer-args and the value as separate arguments causes Helm to interpret the value as its own flag. Using the --post-renderer-args=VALUE format unambiguously binds the value to the flag. Fixes #2563 Signed-off-by: yxxhero <[email protected]>

Copilot

Pull request overview

This PR updates how Helmfile constructs Helm CLI arguments for --post-renderer-args to avoid Helm mis-parsing post-renderer argument values that look like flags (e.g. -v), addressing issue #2563.

Changes:

Emit post-renderer args as --post-renderer-args=VALUE (single argv token) instead of --post-renderer-args VALUE.
Update state flag expectation tests to match the new argv form.
Extend a test helper to recognize both --flag value and --flag=value styles.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
pkg/state/helmx.go	Changes post-renderer-args flag emission to `--post-renderer-args=...`.
pkg/state/state_test.go	Updates expected flag slices for upgrade/template flag generation.
pkg/app/app_test.go	Updates helper to detect `--flag=value` style flags in captured argv.

 		}
+		if f == flagName+"="+value {
+			return true
+		}


 	for _, arg := range postRendererArgsFlags {
 		if arg != "" {
-			flags = append(flags, "--post-renderer-args", arg)
+			flags = append(flags, "--post-renderer-args="+arg)
 		}
 	}


yxxhero · 2026-05-02T01:25:36Z

@copilot fix comments.

- Update hasFlagWithValue doc comment to describe both '--flag value' and '--flag=value' forms - Update t.Errorf messages in app_test.go to reflect both accepted formats - Add 'post-renderer-args-short-flag-value' test case (-v) to both TestHelmState_flagsForUpgrade and TestHelmState_flagsForTemplate to verify --post-renderer-args=-v emission (core regression from #2563) Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/dd95f046-358b-4867-9069-9432c1b5318e Co-authored-by: yxxhero <[email protected]>

Copilot · 2026-05-02T01:31:26Z

@copilot fix comments.

Done in commit 06b9661:

pkg/app/app_test.go: Updated hasFlagWithValue doc comment to describe both --flag value and --flag=value forms, and updated the t.Errorf messages to reflect both accepted formats.
pkg/state/state_test.go: Added post-renderer-args-short-flag-value test cases (using -v) to both TestHelmState_flagsForUpgrade and TestHelmState_flagsForTemplate, verifying that -v is emitted as --post-renderer-args=-v.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

yxxhero requested review from aditmeno, itscaro, mumoshu, xiaomudk and zhaque44 as code owners May 2, 2026 01:08

xiaomudk previously approved these changes May 2, 2026

View reviewed changes

yxxhero requested a review from Copilot May 2, 2026 01:22

Copilot started reviewing on behalf of yxxhero May 2, 2026 01:22 View session

Copilot AI reviewed May 2, 2026

View reviewed changes

Copilot started work on behalf of yxxhero May 2, 2026 01:25 View session

Copilot AI dismissed xiaomudk’s stale review via 06b9661 May 2, 2026 01:31

Copilot finished work on behalf of yxxhero May 2, 2026 01:32

yxxhero requested review from Copilot and xiaomudk May 2, 2026 01:33

Copilot started reviewing on behalf of yxxhero May 2, 2026 01:33 View session

Copilot AI reviewed May 2, 2026

View reviewed changes

xiaomudk approved these changes May 2, 2026

View reviewed changes

yxxhero merged commit a8e8b67 into main May 2, 2026
20 checks passed

yxxhero deleted the fix/post-renderer-args-flag-parsing branch May 2, 2026 02:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: use --post-renderer-args=VALUE format to prevent Helm flag parsing failure#2570

fix: use --post-renderer-args=VALUE format to prevent Helm flag parsing failure#2570
yxxhero merged 2 commits into
mainfrom
fix/post-renderer-args-flag-parsing

yxxhero commented May 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

yxxhero commented May 2, 2026

Uh oh!

Copilot AI commented May 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

yxxhero commented May 2, 2026

Summary

Problem

Solution

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

yxxhero commented May 2, 2026

Uh oh!

Copilot AI commented May 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants