Honor `skipSchemaValidation` during chartification when `forceNamespace` is set by Copilot · Pull Request #2550 · helmfile/helmfile

Copilot · 2026-04-22T23:41:00Z

When a release uses forceNamespace, Helmfile runs chartify before rendering. In that path, skipSchemaValidation was not propagated to chartify’s internal helm template, so schema validation still ran despite skipSchemaValidation: true.

Root cause
- --skip-schema-validation was applied to Helmfile’s final template/upgrade flags, but not to chartify TemplateArgs used in the forceNamespace path.
Behavior change
- Reused skip-schema resolution logic via shouldSkipSchemaValidation(...) so release-level and helmDefaults config are evaluated consistently.
- Appended --skip-schema-validation to chartify TemplateArgs during processChartification(...) when effective skip-schema is enabled.
- Added token-aware arg detection to avoid false positives from substring matches and prevent duplicate flag insertion.
Regression coverage
- Added focused tests (pkg/state/issue_2549_test.go) covering:
  - release-level enablement
  - helmDefaults enablement
  - append with existing args
  - no duplication when already present
  - substring-lookalike args not treated as existing flag

chartifyOpts.TemplateArgs = st.appendSkipSchemaValidationFlagToChartifyTemplateArgs(
    chartifyOpts.TemplateArgs,
    release,
)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

istio-release.storage.googleapis.com
- Triggering command: /usr/local/bin/helm helm repo add istio REDACTED --force-update k/helmfile/helmf-plugin-opt=-pass-through=-lgcc_s /home/REDACTED/go/-plugin-opt=-pass-through=-lc -errorsas (dns block)
- Triggering command: /usr/local/bin/helm helm repo add istio REDACTED --force-update -mode elm -var goCover_53347417dependency nk as --64�� -o nk e-handler -bool t rg/[email protected] e-handler (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

This PR fixes schema validation not being skipped during the chartify (“chartification”) path that runs when forceNamespace is set, by propagating --skip-schema-validation into chartify’s internal helm template arguments.

Changes:

Append --skip-schema-validation to chartify TemplateArgs when the effective config enables skip-schema-validation.
Refactor skip-schema decision logic into shouldSkipSchemaValidation(...) for reuse.
Add unit tests to validate flag appending behavior and token-aware detection/duplication avoidance.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
pkg/state/state.go	Adds logic to append `--skip-schema-validation` into chartify `TemplateArgs` during `processChartification`, plus token-aware arg detection helpers.
pkg/state/helmx.go	Extracts shared `shouldSkipSchemaValidation(...)` helper and reuses it from Helm flag construction.
pkg/state/issue_2549_test.go	Adds focused unit tests for chartify template-arg flag propagation and duplication/lookalike handling.

+func (st *HelmState) appendSkipSchemaValidationFlagToChartifyTemplateArgs(templateArgs string, release *ReleaseSpec) string {
+	if !st.shouldSkipSchemaValidation(release, false) || hasTemplateArg(templateArgs, "--skip-schema-validation") {
+		return templateArgs
+	}
+
+	return appendTemplateArg(templateArgs, "--skip-schema-validation")


yxxhero · 2026-04-23T23:32:53Z

@copilot fix ci issue.

Copilot · 2026-04-23T23:48:31Z

@copilot fix ci issue.

Fixed in fd3f25c. I propagated CLI --skip-schema-validation through chart preparation so chartify now honors it in the forceNamespace path (diff/template/sync/apply), and added regression coverage for the CLI-driven case. I also checked the latest failing Go workflow logs: the previous integration failure was a transient Bitnami repo timeout (context deadline exceeded).

Copilot

Pull request overview

Ensures Helmfile’s skipSchemaValidation setting is honored when chartification runs (notably in the forceNamespace path), by propagating --skip-schema-validation into chartify’s internal helm template invocation.

Changes:

Plumbs SkipSchemaValidation through ChartPrepareOptions and the app command paths that prepare charts.
Updates processChartification(...) to append --skip-schema-validation into chartifyOpts.TemplateArgs when effectively enabled, with token-aware detection to avoid duplicates/substring false-positives.
Refactors skip-schema resolution into shouldSkipSchemaValidation(...) and adds focused unit coverage for the new TemplateArgs behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
pkg/state/state.go	Adds `ChartPrepareOptions.SkipSchemaValidation` and appends `--skip-schema-validation` to chartify TemplateArgs during chartification with duplicate-safe detection.
pkg/state/issue_2549_test.go	Adds unit tests covering release/default/CLI enablement and duplicate/substr handling for chartify TemplateArgs.
pkg/state/helmx.go	Extracts/centralizes the effective skip-schema decision into `shouldSkipSchemaValidation(...)` for reuse.
pkg/app/app.go	Passes CLI `SkipSchemaValidation()` into `ChartPrepareOptions` for diff/template/sync/apply chart preparation.

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/a695cbff-c37a-403a-9658-09f4fdaa65d0 Co-authored-by: yxxhero <[email protected]>

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/70ebf027-0ab5-4bdb-a4b4-5a77c822ee95 Co-authored-by: yxxhero <[email protected]>

Copilot AI assigned Copilot and yxxhero Apr 22, 2026

Copilot started work on behalf of yxxhero April 22, 2026 23:41 View session

Copilot AI linked an issue Apr 22, 2026 that may be closed by this pull request

forceNamespace seems to disable skipSchemaValidation flag #2549

Closed

Copilot AI changed the title ~~[WIP] Fix issue with skipSchemaValidation flag and forceNamespace~~ Honor skipSchemaValidation during chartification when forceNamespace is set Apr 23, 2026

Copilot finished work on behalf of yxxhero April 23, 2026 00:04

Copilot AI requested a review from yxxhero April 23, 2026 00:04

yxxhero requested a review from Copilot April 23, 2026 03:48

Copilot started reviewing on behalf of yxxhero April 23, 2026 03:48 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Copilot started work on behalf of yxxhero April 23, 2026 23:33 View session

Copilot finished work on behalf of yxxhero April 23, 2026 23:49

yxxhero marked this pull request as ready for review April 25, 2026 02:59

yxxhero requested review from aditmeno, itscaro, mumoshu, xiaomudk and zhaque44 as code owners April 25, 2026 02:59

yxxhero requested a review from Copilot April 25, 2026 02:59

Copilot started reviewing on behalf of yxxhero April 25, 2026 02:59 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Copilot AI and others added 3 commits April 30, 2026 12:08

fix(state): honor skipSchemaValidation in chartify template args

c8f831d

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/a695cbff-c37a-403a-9658-09f4fdaa65d0 Co-authored-by: yxxhero <[email protected]>

test(state): harden chartify skip-schema flag detection

075a998

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/a695cbff-c37a-403a-9658-09f4fdaa65d0 Co-authored-by: yxxhero <[email protected]>

fix(state): propagate cli skip-schema-validation to chartify

f6d9fe3

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/70ebf027-0ab5-4bdb-a4b4-5a77c822ee95 Co-authored-by: yxxhero <[email protected]>

zhaque44 force-pushed the copilot/fix-skip-schema-validation branch from fd3f25c to f6d9fe3 Compare April 30, 2026 16:08

zhaque44 approved these changes Apr 30, 2026

View reviewed changes

zhaque44 merged commit 10deabb into main Apr 30, 2026
16 checks passed

zhaque44 deleted the copilot/fix-skip-schema-validation branch April 30, 2026 16:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Honor `skipSchemaValidation` during chartification when `forceNamespace` is set#2550

Honor `skipSchemaValidation` during chartification when `forceNamespace` is set#2550
zhaque44 merged 3 commits into
mainfrom
copilot/fix-skip-schema-validation

Copilot AI commented Apr 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

yxxhero commented Apr 23, 2026

Uh oh!

Copilot AI commented Apr 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Copilot AI commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

yxxhero commented Apr 23, 2026

Uh oh!

Copilot AI commented Apr 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 22, 2026 •

edited

Loading