fix: helmDefaults.postRendererArgs not passed to helm commands by yxxhero · Pull Request #2510 · helmfile/helmfile

yxxhero · 2026-04-01T00:56:44Z

Summary

Root cause: Commit feat: execute templates against postRendererHooks #1839 (b5eb879) added template expression support for postRendererArgs by copying HelmDefaults.PostRendererArgs to each release, then niling out HelmDefaults.PostRendererArgs. This approach had two bugs: (1) the nil-out prevented the fallback in appendPostRenderArgsFlags from ever being reached, and (2) the copy made release.PostRendererArgs non-empty for all releases, causing CLI --post-renderer-args to be silently ignored (since the priority in appendPostRenderArgsFlags is release > CLI > helmDefaults, copied args looked like release-level args).
Fix: Remove the entire copy loop (and the nil assignment) from desired_state_file_loader.go. The existing priority logic in appendPostRenderArgsFlags (release > CLI > helmDefaults) already handles all cases correctly without any copying — st.HelmDefaults.PostRendererArgs is checked as the natural fallback when neither release-level nor CLI args are provided.
Tests: Added unit tests for flagsForUpgrade and flagsForTemplate covering helmDefault, release-level, and release-overrides-helmdefault scenarios. Added app-level table-driven tests covering: helmDefaults args applied (single-doc and multi-doc), and CLI args overriding helmDefaults (single-doc and multi-doc).

How to reproduce the issue

helmDefaults:
  postRenderer: foo
  postRendererArgs:
    - bar

releases:
- name: foo
  chart: charts/foo

Before fix: helmfile template produces helm template foo charts/foo --post-renderer foo (missing --post-renderer-args bar)

After fix: helmfile template produces helm template foo charts/foo --post-renderer foo --post-renderer-args bar

CLI --post-renderer-args also correctly overrides helmDefaults.postRendererArgs when provided.

yxxhero · 2026-04-01T01:13:04Z

@copilot review and fix ci issue.

Copilot · 2026-04-01T01:25:07Z

@copilot review and fix ci issue.

Fixed in 297c038. The CI failure was in TestTemplate_HelmDefaultsPostRendererArgsFromDefaults and TestTemplate_HelmDefaultsPostRendererArgsMultiDoc. When running with HELMFILE_HELM4=1, appendPostRenderFlags strips .sh/.bash extensions from post-renderer paths (converting them to plugin names), so foo.sh → foo. The tests were asserting --post-renderer foo.sh but getting --post-renderer foo. Fixed by using postRenderer := "foo" (no extension) in both tests so the value is unaffected by Helm 4's script-to-plugin-name conversion.

Copilot

Pull request overview

Fixes a regression where helmDefaults.postRendererArgs could be dropped during multi-document/part Helmfile loading, causing helm commands (notably template) to miss --post-renderer-args unless release-level args or CLI args were provided.

Changes:

Stop clearing finalState.HelmDefaults.PostRendererArgs during desired-state load so helmDefaults can still be used as a fallback after merging multiple YAML documents/parts.
Add unit tests for flagsForUpgrade and flagsForTemplate to validate postRendererArgs precedence between helmDefaults and release-level settings.
Add app-level tests to cover single-doc and multi-doc Helmfile YAML cases for helmDefaults.postRendererArgs propagation into helm template invocations.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
pkg/app/desired_state_file_loader.go	Preserves `HelmDefaults.PostRendererArgs` across merged YAML parts so fallback logic can work for multi-doc inputs.
pkg/state/state_test.go	Adds unit coverage for `--post-renderer-args` flag emission and precedence in upgrade/template flag builders.
pkg/app/app_test.go	Adds integration-style tests ensuring `helm template` receives `--post-renderer-args` for single- and multi-doc Helmfiles.

Copilot · 2026-04-01T12:57:18Z

 				}
 			}
-			finalState.HelmDefaults.PostRendererArgs = nil
 		}


The loader still copies helmDefaults.postRendererArgs into every release that doesn’t define postRendererArgs. That makes release.PostRendererArgs non-empty, so appendPostRenderArgsFlags will always pick the (copied) release args and ignore CLI --post-renderer-args, even though the precedence in appendPostRenderArgsFlags is release > CLI > helmDefaults. Consider avoiding this unconditional copy (or tracking that the release args were inherited) so CLI flags can override helmDefaults as intended, and add a regression test for CLI-overrides-helmDefaults behavior (especially for multi-doc helmfiles).

yxxhero · 2026-04-02T06:37:31Z

@copilot fix comments

Copilot · 2026-04-02T06:54:28Z

@copilot fix comments

Fixed in 3f881e4. Removed the copy loop from desired_state_file_loader.go that was incorrectly copying HelmDefaults.PostRendererArgs into each release's PostRendererArgs. This made releases appear to have their own args, causing appendPostRenderArgsFlags to always pick the first case (release args) and skip the CLI args case. The existing fallback logic (release > CLI > helmDefaults) in appendPostRenderArgsFlags already handles priority correctly without any copying. Also added regression tests for CLI-overrides-helmDefaults in both single-doc and multi-doc helmfiles, and refactored the 4 duplicated test functions into 2 table-driven tests.

The commit b5eb879 (#1839) added template support for postRendererArgs by copying HelmDefaults.PostRendererArgs to each release and then niling out HelmDefaults.PostRendererArgs. However, the nil-out prevented the fallback in appendPostRenderArgsFlags from ever being reached, causing helmDefaults.postRendererArgs to be silently ignored when no release-level postRendererArgs was set. Remove the nil-out line so that HelmDefaults.PostRendererArgs remains available as a fallback while still supporting template expressions via the copy-to-release mechanism. Signed-off-by: yxxhero <[email protected]>

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/17a1a3c2-e104-49c5-a607-1e81a7b9de06 Co-authored-by: yxxhero <[email protected]>

…Defaults Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/c85f0436-2346-402e-8ad6-e08a4fff7413 Co-authored-by: yxxhero <[email protected]>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Copilot · 2026-04-15T13:56:58Z

 		if finalState == nil {
 			finalState = currentState
 		} else {
 			if err := mergo.Merge(&finalState.ReleaseSetSpec, &currentState.ReleaseSetSpec, mergo.WithOverride); err != nil {
 				return nil, err
 			}

 			finalState.RenderedValues = currentState.RenderedValues
 		}


Removing the HelmDefaults.PostRendererArgs → Release.PostRendererArgs copy means helmDefaults.postRendererArgs will no longer be run through ReleaseSpec.ExecuteTemplateExpressions. Any helmDefaults args that rely on release-scoped template data (e.g. "{{ .Release.Name }}") used to work via the copy, but will now be passed to helm unrendered. If that templating behavior is still intended, consider rendering helmDefaults.postRendererArgs per-release at flag construction time (using the same release template data) or reintroduce a post-merge inheritance step that preserves CLI precedence without nil-ing HelmDefaults.

Copilot · 2026-04-15T13:56:59Z

+		{
+			name: "post-renderer-args-flags-use-helmdefault",
+			defaults: HelmSpec{
+				Verify:           false,
+				CreateNamespace:  &enable,
+				PostRendererArgs: []string{"--arg1", "--arg2"},
+			},
+			version: semver.MustParse("3.10.0"),
+			release: &ReleaseSpec{
+				Chart:           "test/chart",
+				Version:         "0.1",
+				Verify:          &disable,
+				Name:            "test-charts",
+				Namespace:       "test-namespace",
+				CreateNamespace: &disable,
+			},
+			want: []string{
+				"--version", "0.1",
+				"--post-renderer-args", "--arg1",
+				"--post-renderer-args", "--arg2",
+				"--namespace", "test-namespace",
+			},
+		},


The new table tests cover helmDefaults vs release precedence, but there is no unit test asserting CLI PostRendererArgs (opt.PostRendererArgs) overrides helmDefaults when release.PostRendererArgs is empty. Since the regression also involved CLI args being ignored, please add a case for flagsForUpgrade exercising CLI > helmDefaults, and ideally one verifying release > CLI still holds.

Copilot · 2026-04-15T13:56:59Z

+			// CLI provides --post-renderer-args which should override helmDefaults.postRendererArgs
+			if err := app.Template(configImpl{postRendererArgs: []string{"--cli-arg"}}); err != nil {
+				t.Fatalf("%v", err)
+			}


The app-level tests validate CLI args overriding helmDefaults for template, but they don't cover the higher-priority case where a release explicitly sets postRendererArgs and the CLI also provides --post-renderer-args (expected: release wins per appendPostRenderArgsFlags). Adding a test for release > CLI would help lock in the documented priority and prevent future regressions.

yxxhero · 2026-04-15T23:14:08Z

@copilot fix comments

…iority tests Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/37cf3613-a4e1-4eac-b6bc-002761256d31 Co-authored-by: yxxhero <[email protected]>

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/37cf3613-a4e1-4eac-b6bc-002761256d31 Co-authored-by: yxxhero <[email protected]>

Copilot · 2026-04-15T23:29:27Z

@copilot fix comments

Fixed in 7593d6f. Added the missing tests:

pkg/state/state_test.go:

post-renderer-args-cli-overrides-helmdefault in both flagsForUpgrade and flagsForTemplate: verifies CLI PostRendererArgs takes priority over helmDefaults.postRendererArgs when the release has none
post-renderer-args-release-overrides-cli in both: verifies release-level PostRendererArgs takes priority over CLI args

pkg/app/app_test.go:

TestTemplate_ReleasePostRendererArgsOverridesCLI: app-level table-driven test (single-doc and multi-doc) confirming release args win when both release and CLI provide --post-renderer-args

Regarding the template rendering note from the automated reviewer: HelmDefaults.PostRendererArgs was never run through ExecuteTemplateExpressions before commit b5eb879 introduced the buggy copy loop. This PR restores the pre-b5eb8793 behavior where helmDefaults.postRendererArgs are used as literal values without per-release template rendering.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot · 2026-04-15T23:56:58Z

+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			files := map[string]string{"/path/to/helmfile.yaml": tt.content}
+			var helm = &mockHelmExec{}
+
+			var buffer bytes.Buffer
+			syncWriter := testhelper.NewSyncWriter(&buffer)
+			logger := helmexec.NewLogger(syncWriter, "debug")
+
+			valsRuntime, err := vals.New(vals.Options{CacheSize: 32})
+			if err != nil {
+				t.Fatalf("unexpected error creating vals runtime: %v", err)
+			}
+
+			app := appWithFs(&App{
+				OverrideHelmBinary:              DefaultHelmBinary,
+				fs:                              ffs.DefaultFileSystem(),
+				OverrideKubeContext:             "default",
+				DisableKubeVersionAutoDetection: true,
+				Env:                             "default",
+				Logger:                          logger,
+				helms: map[helmKey]helmexec.Interface{
+					createHelmKey("helm", "default"): helm,
+				},
+				valsRuntime: valsRuntime,
+			}, files)
+
+			if err := app.Template(configImpl{}); err != nil {
+				t.Fatalf("%v", err)
+			}


These new Template tests duplicate substantial setup (fs/app/logger/vals runtime creation and repeated flag scanning logic). Consider extracting a small helper to build the App+mockHelmExec and to assert presence/absence of specific flag/value pairs; it will make the tests shorter and less error-prone to extend (e.g. for additional post-renderer flag scenarios).

Copilot · 2026-04-15T23:56:59Z

 			finalState.RenderedValues = currentState.RenderedValues
 		}

-		if len(finalState.HelmDefaults.PostRendererArgs) > 0 {
-			for i := range finalState.Releases {
-				if len(finalState.Releases[i].PostRendererArgs) == 0 {
-					finalState.Releases[i].PostRendererArgs = finalState.HelmDefaults.PostRendererArgs
-				}
-			}
-			finalState.HelmDefaults.PostRendererArgs = nil
-		}
 		env = &finalState.Env

 		ld.logger.Debugf("merged environment: %v", env)


Removing the HelmDefaults.PostRendererArgs → release.PostRendererArgs copy loop fixes the CLI/default precedence issue, but it also means helmDefaults.postRendererArgs values will no longer have template expressions rendered with per-release context (ExecuteTemplates only renders ReleaseSpec.PostRendererArgs). If templated helmDefaults.postRendererArgs was an intended feature from #1839 (e.g. using {{ .Release.Name }}), this change will regress it; consider rendering the selected args at flag-construction time (based on the existing precedence) instead of copying into release, and add a regression test for templated helmDefaults.postRendererArgs.

yxxhero · 2026-04-16T00:10:23Z

@copilot fix comments

… in app_test.go Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/faf50bca-33b2-4eb4-8ef1-49f470dfa5b7 Co-authored-by: yxxhero <[email protected]>

Copilot · 2026-04-16T00:19:03Z

@copilot fix comments

Fixed in e530c57. Extracted two helpers in pkg/app/app_test.go:

newPostRendererTestApp(t, files) — creates the App + mockHelmExec pair so each test function no longer repeats the 20-line setup block.
hasFlagWithValue(flags, flagName, value) — replaces the inline for-loops that scan for adjacent --flag value pairs.

All three test functions (TestTemplate_HelmDefaultsPostRendererArgs, TestTemplate_CLIPostRendererArgsOverridesHelmDefaults, TestTemplate_ReleasePostRendererArgsOverridesCLI) now use these helpers, reducing ~120 lines of duplicated boilerplate to ~47 lines.

Regarding the template-rendering concern from the automated reviewer: HelmDefaults.PostRendererArgs was never rendered with per-release context before commit b5eb879 introduced the (buggy) copy loop. This PR restores that pre-b5eb8793 behavior. Supporting {{ .Release.Name }} in helmDefaults.postRendererArgs would be a separate enhancement.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

allanger · 2026-05-04T10:01:33Z

https://gh.io/copilot-coding-agent-docs fix comments

It seems like the comments were not fixed, and now the logic for templating the args is broken. May we consider fixing the helmDefaults behaviour without breaking arg templating?

UPD: I mean, may it be considered if I'm able to rewrite this logic without breaking cli args and helmDefaults?

yxxhero · 2026-05-04T11:46:15Z

@allanger could you post an new issue？

PR #1839 introduced template rendering for postRendererArgs, but PR #2510 reverted it while fixing a separate regression. This left helmDefaults-level postRendererArgs containing template expressions (e.g. {{ .Release.Name }}) passed to helm as literal strings instead of being resolved per-release. Add renderPostRendererArgs() that templates helmDefaults.postRendererArgs at flag-generation time using the release's template data, reusing the existing createReleaseTemplateData() helper. Release-level args are already templated by ExecuteTemplateExpressions and CLI args are static, so only the helmDefaults path needs rendering. Fixes #2580 Signed-off-by: opencode <[email protected]> Signed-off-by: yxxhero <[email protected]>

yxxhero requested review from aditmeno, itscaro, mumoshu, xiaomudk and zhaque44 as code owners April 1, 2026 00:56

Copilot started work on behalf of yxxhero April 1, 2026 01:13 View session

Copilot finished work on behalf of yxxhero April 1, 2026 01:26

yxxhero requested a review from Copilot April 1, 2026 12:51

Copilot started reviewing on behalf of yxxhero April 1, 2026 12:52 View session

yxxhero force-pushed the fix/helmdefaults-postrendererargs-2508 branch from 297c038 to d68aa3a Compare April 1, 2026 12:55

Copilot AI reviewed Apr 1, 2026

View reviewed changes

Copilot started work on behalf of yxxhero April 2, 2026 06:37 View session

Copilot finished work on behalf of yxxhero April 2, 2026 06:56

yxxhero and others added 3 commits April 9, 2026 20:52

fix: use helm4-compatible postRenderer value in app tests

17ae231

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/17a1a3c2-e104-49c5-a607-1e81a7b9de06 Co-authored-by: yxxhero <[email protected]>

yxxhero force-pushed the fix/helmdefaults-postrendererargs-2508 branch from 3f881e4 to 552b8e8 Compare April 9, 2026 12:52

yxxhero requested a review from Copilot April 15, 2026 13:49

Copilot started reviewing on behalf of yxxhero April 15, 2026 13:49 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Copilot started work on behalf of yxxhero April 15, 2026 23:14 View session

Copilot AI and others added 2 commits April 15, 2026 23:24

fix: clarify comment wording in app_test.go

3bd1005

Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/37cf3613-a4e1-4eac-b6bc-002761256d31 Co-authored-by: yxxhero <[email protected]>

Copilot finished work on behalf of yxxhero April 15, 2026 23:30

yxxhero requested a review from Copilot April 15, 2026 23:52

Copilot started reviewing on behalf of yxxhero April 15, 2026 23:53 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Copilot started work on behalf of yxxhero April 16, 2026 00:10 View session

Copilot finished work on behalf of yxxhero April 16, 2026 00:19

yxxhero requested a review from Copilot April 16, 2026 00:29

Copilot started reviewing on behalf of yxxhero April 16, 2026 00:30 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

xiaomudk approved these changes Apr 16, 2026

View reviewed changes

yxxhero merged commit c584c0e into main Apr 16, 2026
31 of 42 checks passed

yxxhero deleted the fix/helmdefaults-postrendererargs-2508 branch April 16, 2026 03:08

allanger mentioned this pull request May 7, 2026

Global post renderer argumetes are not templated with release data after fixing helm defaults #2580

Closed

yxxhero mentioned this pull request May 8, 2026

fix: template helmDefaults.postRendererArgs with release data #2583

Merged

Uh oh!

Uh oh!

Conversation

yxxhero commented Apr 1, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to reproduce the issue

Uh oh!

yxxhero commented Apr 1, 2026

Uh oh!

Copilot AI commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

yxxhero commented Apr 2, 2026

Uh oh!

Copilot AI commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

yxxhero commented Apr 15, 2026

Uh oh!

Copilot AI commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

yxxhero commented Apr 16, 2026

Uh oh!

Copilot AI commented Apr 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

allanger commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yxxhero commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yxxhero commented Apr 1, 2026 •

edited by Copilot AI

Loading

allanger commented May 4, 2026 •

edited

Loading