fix: helmfile list now reflects version from helmfile.lock by yxxhero · Pull Request #2486 · helmfile/helmfile

yxxhero · 2026-03-15T07:56:13Z

Summary

The helmfile list command now resolves locked dependencies before returning release information
This ensures the version field reflects the pinned version from helmfile.lock when present
Uses ResolveDeps() to merge locked dependency versions into the release state

Fixes #1953

Testing

Added TestListWithLockFileVersion test that verifies the version from helmfile.lock is reflected in the output
All existing list tests continue to pass

Copilot

Pull request overview

Updates helmfile list to incorporate dependency resolution so chart version reflects pinned values from helmfile.lock when available, aligning list output with locked dependency state.

Changes:

Resolve locked chart dependency versions during helmfile list via ResolveDeps().
Adjust label merging implementation in list output generation.
Add a unit test validating that JSON output reports the version from helmfile.lock.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
pkg/app/app.go	Resolves dependencies before listing releases so `Version` can reflect `helmfile.lock`.
pkg/app/app_list_test.go	Adds a regression test to ensure list JSON output shows the locked chart version.

 		if r.Labels == nil {
 			r.Labels = map[string]string{}
 		}
-		for k, v := range run.state.CommonLabels {
-			r.Labels[k] = v
-		}
+		maps.Copy(r.Labels, resolvedState.CommonLabels)



+func TestListWithLockFileVersion(t *testing.T) {
+	files := map[string]string{
+		"/path/to/helmfile.yaml": `
+repositories:
+- name: bitnami
+  url: https://charts.bitnami.com/bitnami
+


+	resolvedState, err := run.state.ResolveDeps()
+	if err != nil {
+		return nil, fmt.Errorf("unable to resolve dependencies: %w", err)
+	}


Copilot

Pull request overview

Updates helmfile list to report chart versions pinned in helmfile.lock (when present) by resolving locked dependencies before emitting release data, improving correctness for users relying on lockfiles (Fixes #1953).

Changes:

Call HelmState.ResolveDeps() during list so HelmRelease.Version reflects the locked chart version.
Fix lockfile path resolution for states loaded with baseDir/basePath (so the default lockfile is found without changing CWD).
Add list tests validating locked-version output for single-file and helmfile.d multi-file scenarios.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
pkg/app/app.go	Resolves dependencies before listing releases so versions can come from `helmfile.lock`.
pkg/state/chart_dependency.go	Adjusts default lockfile path resolution relative to `basePath` for dependency merging.
pkg/state/state_test.go	Updates `ResolveDeps` test stub expectations for the new lockfile path behavior.
pkg/app/app_list_test.go	Adds JSON-output tests asserting `list` uses locked versions from lockfiles.

+	switch {
+	case lockFile != "":
+		if st.basePath != "" && !filepath.IsAbs(lockFile) {
+			lockFile = filepath.Join(st.basePath, lockFile)
+		}
+	case st.basePath != "":
+		// When no custom lockfile is specified, use the default lockfile name
+		// joined with basePath to ensure it's found when not changing CWD.
+		lockFile = filepath.Join(st.basePath, filename+".lock")
 	}


+  repository: https://charts.bitnami.com/bitnami
+  version: 17.0.7
+  digest: sha256:abc123
+  generated: "2024-01-01T00:00:00Z"
+`,


+  repository: https://charts.bitnami.com/bitnami
+  version: 15.0.0
+  digest: sha256:def456
+  generated: "2024-01-01T00:00:00Z"
+`,


Copilot

Pull request overview

Updates helmfile list to reflect chart versions pinned in helmfile.lock by resolving locked dependencies before producing release output, bringing list behavior in line with dependency-aware commands.

Changes:

Resolve locked chart dependency versions during list via HelmState.ResolveDeps().
Make default lockfile path resolution respect basePath when no custom lockfile is configured.
Add list tests validating lockfile-pinned versions (single helmfile and multi-file directory cases).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
pkg/app/app.go	Runs `ResolveDeps()` before listing releases so the printed `Version` matches `helmfile.lock`.
pkg/state/chart_dependency.go	Resolves default lockfile path relative to `basePath` when `LockFile` is unset.
pkg/state/state_test.go	Adjusts dependency tests to use temp dirs / updated lockfile path expectations.
pkg/app/app_list_test.go	Adds tests asserting `helmfile list --output=json` reports versions from lockfiles.

-	for _, r := range run.state.Releases {
+	resolvedState, err := run.state.ResolveDeps()
+	if err != nil {
+		return nil, fmt.Errorf("unable to resolve dependencies: %w", err)


Copilot

Pull request overview

This PR updates helmfile list to show chart versions pinned in helmfile.lock by resolving locked dependencies before emitting release data, and adjusts dependency lockfile path handling for baseDir/basePath scenarios.

Changes:

Resolve locked dependencies (ResolveDeps()) during helmfile list so release Version reflects helmfile.lock when present.
Fix default lockfile path resolution to be relative to HelmState.basePath when no custom LockFile is configured.
Add list tests asserting helmfile.lock-pinned versions appear in JSON output (single file and multi-file).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
pkg/app/app.go	`list()` now resolves dependencies before building `HelmRelease` output, enabling lockfile-pinned versions to surface in `helmfile list`.
pkg/state/chart_dependency.go	Ensures default lockfile path uses `basePath` when no explicit lockfile is configured (both resolve and update paths).
pkg/app/app_list_test.go	Adds coverage verifying list JSON output uses versions from `helmfile.lock` (including multi-file `helmfile.d`).
pkg/state/state_test.go	Makes dependency tests use temp dirs and updates expectations for lockfile reads under `basePath`.

+	resolvedState, err := run.state.ResolveDeps()
+	if err != nil {
+		return nil, fmt.Errorf("unable to resolve dependencies for %s: %w", run.state.FilePath, err)
+	}


+	resolvedState, err := run.state.ResolveDeps()
+	if err != nil {


Copilot

Pull request overview

This PR updates helmfile list to reflect chart versions pinned in helmfile.lock by resolving/merging locked dependency versions into the state before producing list output.

Changes:

Resolve dependencies in ListReleases via ResolveDeps() so version reflects the lockfile when present.
Ensure default lockfile path resolution respects basePath when no custom lockfile is specified.
Add JSON-based tests validating locked versions are surfaced for single-file and multi-file (helmfile.d) setups.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
pkg/app/app.go	Calls `ResolveDeps()` during list rendering so release versions come from the lockfile.
pkg/state/chart_dependency.go	Fixes default lockfile path resolution to include `basePath` when applicable.
pkg/app/app_list_test.go	Adds tests asserting `helmfile list --output=json` reports versions from `.lock` files.
pkg/state/state_test.go	Adjusts tests to use temp dirs and align lockfile path expectations with updated basePath behavior.

+				stateReleases, listErr = a.list(run)
 			})
+			if listErr != nil {
+				err = listErr


Copilot

Pull request overview

Updates helmfile list so that it reflects chart versions pinned in helmfile.lock by resolving/merging locked dependencies into the state before producing output (addressing #1953).

Changes:

Resolve dependencies (ResolveDeps()) during helmfile list so the version field reflects helmfile.lock when present.
Adjust lockfile path resolution to respect basePath even when no custom lockfile is configured.
Add list tests validating lockfile-pinned versions (single-file and multi-file scenarios).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
pkg/app/app.go	Calls `ResolveDeps()` as part of list rendering; adjusts error handling for `withPreparedCharts` callback.
pkg/state/chart_dependency.go	Uses `basePath`-joined default lockfile path when `LockFile` is unset (for both resolve and update).
pkg/app/app_list_test.go	Adds tests asserting `helmfile list --output=json` reports versions from `helmfile.lock`.
pkg/state/state_test.go	Updates dependency-related tests to use a temp base path and align expected lockfile paths.

+			if listErr != nil && err == nil {
+				err = listErr


 			err = run.withPreparedCharts("list", state.ChartPrepareOptions{
 				SkipRepos:   true,
 				SkipDeps:    true,
+				SkipResolve: true,


+		"/example/Chart.yaml":                         `foo: FOO`,
+		filepath.Join(basePath, "example/Chart.yaml"): `foo: FOO`,
 	})
 	fs.Cwd = basePath


Copilot

Pull request overview

This PR updates helmfile list to report chart versions as resolved from helmfile.lock (when present), aligning list output with the versions that would actually be used after dependency locking.

Changes:

Resolve locked dependencies during helmfile list so the displayed Version reflects pinned lockfile versions.
Improve lockfile path resolution when basePath is set (default lockfile now resolved relative to basePath).
Add list-focused tests that assert lockfile-pinned versions appear in JSON output (including multi-file helmfile.d cases).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
pkg/app/app.go	Calls `ResolveDeps()` during list construction so release versions can come from `helmfile.lock`; removes panic path in list flow.
pkg/state/chart_dependency.go	Ensures default lockfile path is resolved relative to `basePath` when no custom lockfile is set.
pkg/app/app_list_test.go	Adds tests validating `helmfile list --output json` reflects lockfile-pinned versions (single + multi-file).
pkg/state/state_test.go	Updates tests to use temp dirs / adjusted paths to match the updated lockfile-path behavior.

 		if !c.SkipCharts() {
 			err = run.withPreparedCharts("list", state.ChartPrepareOptions{
 				SkipRepos:   true,
 				SkipDeps:    true,
 				Concurrency: 2,
 			}, func() {
-				rel, err := a.list(run)
-				if err != nil {
-					panic(err)
-				}
-				stateReleases = rel
+				stateReleases, err = a.list(run)
 			})


Copilot

Pull request overview

This PR updates helmfile list to resolve chart versions from helmfile.lock (when present) so the listed release versions reflect pinned/locked dependency versions rather than only the version constraints in helmfile.yaml.

Changes:

Call ResolveDeps() during helmfile list release collection so locked dependency versions are merged into the state prior to formatting output.
Adjust dependency lockfile path resolution to correctly locate the default <helmfile-basename>.lock under basePath when no custom lockfile is specified.
Add unit tests validating helmfile list --output=json returns versions from lock files (single-file and multi-file cases).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
pkg/app/app.go	Resolves deps before listing releases; improves error propagation in `ListReleases`.
pkg/state/chart_dependency.go	Ensures default lockfile path is joined with `basePath` when `LockFile` is not explicitly set.
pkg/app/app_list_test.go	Adds tests verifying list output uses versions from `helmfile.lock` (including multi-helmfile cases).
pkg/state/state_test.go	Updates dependency-resolution tests to use temp base paths and validate new lockfile path behavior.

The list command now resolves locked dependencies before returning release information, ensuring the version field reflects the pinned version from helmfile.lock when present. Fixes #1953 Signed-off-by: yxxhero <[email protected]>

- Remove redundant maps.Copy in list() - labels already merged by GetReleasesWithLabels() - Fix default lockfile path to use basePath for multi-file mode - Update test to expect basePath-joined lockfile path - Add multi-file test for lockfile resolution in helmfile.d directory Signed-off-by: yxxhero <[email protected]>

Signed-off-by: yxxhero <[email protected]>

When skipCharts=false, errors from list() now properly propagate instead of causing a crash. Uses a closure variable to capture the error and propagates it after withPreparedCharts completes. Signed-off-by: yxxhero <[email protected]>

Signed-off-by: yxxhero <[email protected]>

yxxhero requested review from aditmeno, itscaro, mumoshu, xiaomudk and zhaque44 as code owners March 15, 2026 07:56

yxxhero requested a review from Copilot March 15, 2026 09:47

Copilot started reviewing on behalf of yxxhero March 15, 2026 09:47 View session

Copilot AI reviewed Mar 15, 2026

View reviewed changes

yxxhero requested a review from Copilot March 15, 2026 11:56

Copilot started reviewing on behalf of yxxhero March 15, 2026 11:57 View session

Copilot AI reviewed Mar 15, 2026

View reviewed changes

yxxhero requested a review from Copilot March 16, 2026 00:59

Copilot started reviewing on behalf of yxxhero March 16, 2026 00:59 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Comment thread pkg/app/app.go Outdated

for _, r := range run.state.Releases {

resolvedState, err := run.state.ResolveDeps()

if err != nil {

return nil, fmt.Errorf("unable to resolve dependencies: %w", err)

yxxhero requested a review from Copilot March 16, 2026 03:45

Copilot started reviewing on behalf of yxxhero March 16, 2026 03:46 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

yxxhero requested a review from Copilot March 16, 2026 06:47

Copilot started reviewing on behalf of yxxhero March 16, 2026 06:47 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Comment thread pkg/app/app.go Outdated

stateReleases, listErr = a.list(run)

})

if listErr != nil {

err = listErr

yxxhero force-pushed the fix/list-reflect-lockfile-version branch from 20b4833 to 8d393fd Compare March 18, 2026 01:03

yxxhero requested a review from Copilot March 18, 2026 01:20

Copilot started reviewing on behalf of yxxhero March 18, 2026 01:20 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

yxxhero requested a review from Copilot March 18, 2026 08:30

Copilot started reviewing on behalf of yxxhero March 18, 2026 08:30 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

yxxhero requested a review from Copilot March 18, 2026 09:43

Copilot started reviewing on behalf of yxxhero March 18, 2026 09:44 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

yxxhero added 8 commits March 19, 2026 14:19

fix more test

0010ee1

Signed-off-by: yxxhero <[email protected]>

fix tests

1ec386f

Signed-off-by: yxxhero <[email protected]>

fix: propagate errors instead of panic in list()

2b48795

When skipCharts=false, errors from list() now properly propagate instead of causing a crash. Uses a closure variable to capture the error and propagates it after withPreparedCharts completes. Signed-off-by: yxxhero <[email protected]>

fix tests

edd3078

Signed-off-by: yxxhero <[email protected]>

fix tests

7404040

Signed-off-by: yxxhero <[email protected]>

fix tests

3da02c0

Signed-off-by: yxxhero <[email protected]>

yxxhero force-pushed the fix/list-reflect-lockfile-version branch from f9ca590 to 3da02c0 Compare March 19, 2026 06:19

xiaomudk approved these changes Mar 19, 2026

View reviewed changes

yxxhero merged commit df01afb into main Mar 19, 2026
9 checks passed

yxxhero deleted the fix/list-reflect-lockfile-version branch March 19, 2026 06:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: helmfile list now reflects version from helmfile.lock#2486

fix: helmfile list now reflects version from helmfile.lock#2486
yxxhero merged 8 commits into
mainfrom
fix/list-reflect-lockfile-version

yxxhero commented Mar 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		resolvedState, err := run.state.ResolveDeps()
		if err != nil {

Uh oh!

Uh oh!

Conversation

yxxhero commented Mar 15, 2026

Summary

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants