fix: use --force-replace flag for Helm 4 instead of deprecated --force by yxxhero · Pull Request #2477 · helmfile/helmfile

yxxhero · 2026-03-11T00:24:53Z

Summary

Fixes Helm 4 compatibility when using force: true option in helmfile
Helm 4 deprecated --force flag in favor of --force-replace
Adds version detection to use appropriate flag based on Helm version

Changes

Modified flagsForUpgrade in pkg/state/state.go to check Helm version and use --force-replace for Helm 4, --force for Helm 3
Fixed nil pointer panic in appendHideNotesFlags when called with nil SyncOpts
Added test cases for both Helm 3 and Helm 4 force flag behavior

Testing

Added new test cases: force-helm3, force-helm4, force-from-default-helm3, force-from-default-helm4
All existing tests pass

Helm 4 deprecated the --force flag in favor of --force-replace. This fix detects the Helm version and uses the appropriate flag: - Helm 4: --force-replace - Helm 3: --force Also fixed a nil pointer panic in appendHideNotesFlags when called with nil SyncOpts. Fixes #2476 Signed-off-by: yxxhero <[email protected]>

semver@latest requires Go 1.26.1 but the project uses Go 1.25.4. Pinning to v2.12.0 which is compatible with Go 1.25. Signed-off-by: yxxhero <[email protected]>

Copilot

Pull request overview

This PR updates Helmfile’s Helm upgrade flag generation to be compatible with Helm 4 by using --force-replace (instead of deprecated --force) when force: true is enabled, and also hardens flag-building against a nil SyncOpts.

Changes:

Switch force: true handling to emit --force-replace for Helm 4 and --force for Helm 3.
Prevent nil-pointer panic in appendHideNotesFlags when SyncOpts is nil.
Extend unit tests for Helm 3 vs Helm 4 force-flag behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
`pkg/state/state.go`	Choose `--force-replace` vs `--force` based on Helm major version.
`pkg/state/helmx.go`	Add nil guard for `SyncOpts` in `appendHideNotesFlags`.
`pkg/state/state_test.go`	Add/adjust tests to validate force flag behavior for Helm 3 and Helm 4.
`.github/workflows/ci.yaml`	Pin `semver` install to a fixed version for CI stability.

Comments suppressed due to low confidence (1)

pkg/state/state_test.go:340

The new Helm 4 behavior is only tested when release.Force is explicitly set. There’s no test covering the case where release.Force is nil and HelmDefaults.Force enables force, which is part of the updated branching logic and could regress between Helm 3/4. Add test cases for (a) Helm 3 → --force and (b) Helm 4 → --force-replace when force comes from defaults (release-level Force unset).

		{
			name: "force-helm3",
			defaults: HelmSpec{
				Force:           false,
				CreateNamespace: &disable,
			},
			version: semver.MustParse("3.10.0"),
			release: &ReleaseSpec{
				Chart:     "test/chart",
				Version:   "0.1",
				Force:     &enable,
				Name:      "test-charts",
				Namespace: "test-namespace",
			},
			want: []string{
				"--version", "0.1",
				"--force",
				"--namespace", "test-namespace",
			},
		},
		{
			name: "force-helm4",
			defaults: HelmSpec{
				Force:           false,
				CreateNamespace: &disable,
			},
			version: semver.MustParse("4.0.0"),
			release: &ReleaseSpec{
				Chart:     "test/chart",
				Version:   "0.1",
				Force:     &enable,
				Name:      "test-charts",
				Namespace: "test-namespace",
			},
			want: []string{
				"--version", "0.1",
				"--force-replace",
				"--namespace", "test-namespace",
			},
		},
		{
			name: "force-from-default-helm3",
			defaults: HelmSpec{
				Force:           true,
				CreateNamespace: &disable,
			},
			version: semver.MustParse("3.10.0"),
			release: &ReleaseSpec{
				Chart:     "test/chart",
				Version:   "0.1",
				Force:     &disable,
				Name:      "test-charts",
				Namespace: "test-namespace",
			},
			want: []string{
				"--version", "0.1",
				"--namespace", "test-namespace",
			},
		},
		{
			name: "force-from-default-helm4",
			defaults: HelmSpec{
				Force:           true,
				CreateNamespace: &disable,
			},
			version: semver.MustParse("4.0.0"),
			release: &ReleaseSpec{
				Chart:     "test/chart",
				Version:   "0.1",
				Force:     &disable,
				Name:      "test-charts",
				Namespace: "test-namespace",
			},
			want: []string{
				"--version", "0.1",
				"--namespace", "test-namespace",
			},
		},

Copilot · 2026-03-11T10:01:16Z

 func (st *HelmState) appendHideNotesFlags(flags []string, helm helmexec.Interface, ops *SyncOpts) []string {
-	// see https://github.com/helm/helm/releases/tag/v3.16.0
 	if !helm.IsVersionAtLeast("3.16.0") {
 		return flags
 	}
+	if ops == nil {
+		return flags
+	}


This adds a nil guard for ops to prevent a panic, but there’s no regression test ensuring appendHideNotesFlags(..., ops=nil) doesn’t panic and doesn’t add flags (for Helm >= 3.16). Please add a unit test in pkg/state/helmx_test.go that exercises ops == nil to lock in the fix.

Add test cases to cover the scenario where release.Force is nil and HelmDefaults.Force enables force for both Helm 3 and Helm 4. Signed-off-by: yxxhero <[email protected]>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-11T10:13:46Z

+			name: "force-from-default-nil-release-helm3",
+			defaults: HelmSpec{
+				Force:           true,
+				CreateNamespace: &disable,
+			},
+			version: semver.MustParse("3.10.0"),
+			release: &ReleaseSpec{
+				Chart:     "test/chart",
+				Version:   "0.1",
+				Name:      "test-charts",
+				Namespace: "test-namespace",
+			},
+			want: []string{
+				"--version", "0.1",
+				"--force",
+				"--namespace", "test-namespace",
+			},
+		},
+		{
+			name: "force-from-default-nil-release-helm4",
+			defaults: HelmSpec{
+				Force:           true,


The test case names force-from-default-nil-release-helm3/helm4 are misleading: the release itself isn’t nil, only release.Force is unset. Consider renaming to something like force-from-default-nil-force-helm3/helm4 to better reflect what’s being validated.

- Add test case for appendHideNotesFlags with ops=nil to prevent regression - Rename force-from-default-nil-release-* to force-from-default-nil-force-* for clarity (release.Force is nil, not the release itself) Signed-off-by: yxxhero <[email protected]>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-11T10:25:36Z

 	if release.Force != nil && *release.Force || release.Force == nil && st.HelmDefaults.Force {
-		flags = append(flags, "--force")
+		if helm.IsHelm4() {
+			flags = append(flags, "--force-replace")
+		} else {
+			flags = append(flags, "--force")
+		}


The if release.Force != nil && *release.Force || release.Force == nil && st.HelmDefaults.Force condition relies on operator precedence and is easy to misread when modifying this logic further. Consider adding explicit parentheses around the two disjuncts to make the intended grouping unambiguous.

Add explicit parentheses around the two disjuncts in the force condition to make the intended grouping unambiguous and easier to read. Signed-off-by: yxxhero <[email protected]>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-11T10:52:01Z

 	if !helm.IsVersionAtLeast("3.16.0") {
 		return flags
 	}
+	if ops == nil {


appendHideNotesFlags now checks the Helm version before checking ops == nil. Swapping the order to return early when ops is nil avoids an unnecessary IsVersionAtLeast call and makes the function more robust if it’s ever called with a nil helm implementation. Also, consider restoring the nearby "see Helm release" comment for consistency with the other flag helpers in this file (e.g., appendCascadeFlags, appendTakeOwnershipFlagsForUpgrade).

Suggested change

if !helm.IsVersionAtLeast("3.16.0") {

return flags

}

if ops == nil {

if ops == nil {

return flags

}

// see https://github.com/helm/helm/releases/tag/v3.16.0

if !helm.IsVersionAtLeast("3.16.0") {

- Swap the order to check ops == nil first to avoid unnecessary IsVersionAtLeast call - Restore the "see Helm release" comment for consistency with other flag helpers Signed-off-by: yxxhero <[email protected]>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

yxxhero requested review from aditmeno, itscaro, mumoshu, xiaomudk and zhaque44 as code owners March 11, 2026 00:24

fix(ci): pin semver to v2.12.0 for Go 1.25 compatibility

abcef80

semver@latest requires Go 1.26.1 but the project uses Go 1.25.4. Pinning to v2.12.0 which is compatible with Go 1.25. Signed-off-by: yxxhero <[email protected]>

yxxhero requested a review from Copilot March 11, 2026 09:58

Copilot started reviewing on behalf of yxxhero March 11, 2026 09:58 View session

xiaomudk previously approved these changes Mar 11, 2026

View reviewed changes